Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-3163 - Remove all references to TagsByFilter #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tahiyasalam
Copy link
Member

@tahiyasalam tahiyasalam commented Feb 20, 2025

Hey folks! Not sure I'm doing this correctly, but we are in the process of deprecating the TagsByFilter API. As part of that, I'd like to remove all references from the SDK before deprecating in proto. LMK if there's another process you all prefer.

@tahiyasalam tahiyasalam requested a review from a team as a code owner February 20, 2025 20:03
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! the change itself looks reasonable, but I wonder if just removing these methods immediately is the right approach. What is the timeline for removing the TagsByFilter APIs? I think it might make more sense here to leave these methods as they are but add deprecation warnings (see here as an example), that way anyone using these methods will at least have a bit of warning before they go away.

All that said, I have no insight into how much these methods are actually used so I don't feel too strongly! If you prefer to just remove them outright I'm certainly willing to be convinced 🙂

Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were the GRPC/protobuf changes made? I think they're still included in the actual proto changes, so we shouldn't remove them here either. if desired, we should only update the client/tests, but we should leave anything in gen or proto dirs as is

@njooma
Copy link
Member

njooma commented Feb 24, 2025

Further to @stuqdog's comment, is this API being deprecated or removed? If just deprecated, perhaps we also deprecate them in the SDKs instead of removing them entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants