[RSDK-9328] Exclude non-actuating methods #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
stuqdog
approved these changes
Feb 26, 2025
purplenicole730
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only send heartbeats for actuating methods.
I chose to do it this way because (having a list of actuating methods) rather than the opposite (exempting a list of non-actuating methods) because in the API protos, we already have an optional extension calledsafety_heartbeat_monitoredon the RPCs. But there's no way to actually grab that value in the client SDKs, so I instead got all thesafety_heartbeat_monitoredfrom the API protos and listed those out here.Now gets actuating option from proto