Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate unique component id #538

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

underfin
Copy link
Member

@underfin underfin commented Mar 4, 2025

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

The component id using hash for relative path, it could be conflict at module federation. The pr using the absolute path to avoid it.

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented Mar 4, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@538
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@538

commit: acd2814

@@ -49,7 +49,7 @@ export function createDescriptor(
descriptor.id = getHash(normalizedPath + source)
} else if (typeof componentIdGenerator === 'function') {
descriptor.id = componentIdGenerator(
normalizedPath,
normalizePath(path.relative(root, filename)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here perserve the relative path to avoid break change, if the user using it, it should be make sure the unique compoenent id.

The relate test is playground/vue-custom-id/__tests__/vue-custom-id.spec.ts. it using component id to generate attr <h1 data-v-components-foo="">Foo</h1>'.

@underfin underfin marked this pull request as draft March 4, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant