Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinia-devtools-plugin not working with Vue Devtools v6 #2919

Closed
mrleblanc101 opened this issue Feb 24, 2025 · 9 comments · May be fixed by #2923
Closed

pinia-devtools-plugin not working with Vue Devtools v6 #2919

mrleblanc101 opened this issue Feb 24, 2025 · 9 comments · May be fixed by #2923

Comments

@mrleblanc101
Copy link

Reproduction

.

Steps to reproduce the bug

I see Pinia v3 dropped support for Vue 2, but I didn't see any mention of this dropping support for Devtools v6.
Devtools v6 support both Vue 2 and Vue 3.
Is this expected ?

I need Devtools v6 because I support both Vue 2 and Vue 3 project.
It's inconvenient to have to disable Devtools v6 and enable Devtools v7 every time I switch project.

Expected behavior

Maybe Pinia could keep support for both Devtools v6 and v7, but I don't know how much work that would be.
Otherwise, I hope Devtools v7 add support for Vue 2, but I wouldn't hold my breath as Vue 2 EOL.

Actual behavior

.

Additional information

No response

@mrleblanc101
Copy link
Author

Maybe related to #2914 ?

@mrleblanc101
Copy link
Author

mrleblanc101 commented Feb 24, 2025

If this is intended, maybe this deprecation should be included in the changelog

@Cherry
Copy link

Cherry commented Feb 24, 2025

Confirming this impacts Firefox pretty badly too, where Vue Devtools v7 isn't yet distributed on the extensions store, making developing with Pinia in Firefox much more difficult currently.

@mrleblanc101
Copy link
Author

mrleblanc101 commented Feb 24, 2025

Indeed @Cherry, thanks for bringing that up !
I didn't even think about that and I've been following vuejs/devtools#660 for a while.

Copy link
Member

posva commented Feb 24, 2025

You can:

  • use the Vite plugin
  • Stay on Pinia 2
  • Wait until Firefox approves the new version for the devtools

I didn't know the Firefox version was still on v6, that's quite a shame but also nothing I can do about it 😅

@posva posva closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2025
@mrleblanc101
Copy link
Author

mrleblanc101 commented Feb 24, 2025

@posva

  1. I don't know what you mean by vite plugin, I'll look it up.

  2. Ok, but I didnt know I'd lose devtools when i upgraded. There is no mention of this, and there is no warning in the console or anywhere so I lost quite a bit of time.

Can this be documented anywhere ? I feel like a mention in the changelog would be a good place, no ? How are people expected to know that Pinia v3 doesn't support Devtools v6 anymore otherwise ?

  1. The problem is not that v7 is not approved by Firefox, the problem is that the devtools team did not even send the update for approbation... But hopefully that's going to change, I see a team member said he talk to Evan You about this

Copy link
Member

posva commented Feb 24, 2025

It's indeed not in the changelog! It wasn't meant to be a breaking change either. Contribution welcome!

@mrleblanc101
Copy link
Author

mrleblanc101 commented Feb 24, 2025

I'll open a PR, thanks.
Although if I add it to changelog.md, I'm not sure it will update the GitHub Release content.
I might add a mention in the regular doc if I find somewhere suitable

@mrleblanc101
Copy link
Author

@posva I have a basic PR that add a note to the changelog, I also wanted to see if I could add a runtime console.warn() if we detect Pinia >= 3.0.0 when running with Devtools v6, but can't seem to find a way to get the devtools version.

But in my investigation, I found out that Devtools v7 still use the exact same API as Devtools v6, see here.
So now I'm wondering with the plugin wouldn't work with both version, I've reviewed the whole v3 PR and couldn't understand why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants