Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing viewTransition prop on RouterLink #2465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: missing viewTransition prop on RouterLink #2465

wants to merge 1 commit into from

Conversation

lubomirblazekcz
Copy link

No description provided.

@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit b0b3907
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/67b61782f59e5b000840625c

posva
posva reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have you found any case where the lack of the js declaration has an impact?

@posva posva added the needs reproduction This bug hasn't provided a valid reproduction for the bug to be verified label Mar 3, 2025
@lubomirblazekcz
Copy link
Author

Yeah, when I added view-transition="true" on the router-link it didn't work for me at all. After this change it started working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva

Assignees
No one assigned
Labels
needs reproduction This bug hasn't provided a valid reproduction for the bug to be verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubomirblazekcz @posva