Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint more files #2470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skirtles-code
Copy link
Contributor

There are several files that aren't currently being formatted by Prettier. I've tried to expand that to include more files.

  • Add mjs and mts extensions.
  • Add *.html to lint-staged.
  • Expand the paths in lint:script to cover more files in packages, as well as scripts.

Changing the paths in lint:script is probably the trickiest part. It's not entirely clear to me whether I've got those paths correct.

It's worth noting that lint-staged doesn't take those paths into account, it just formats anything with the appropriate extensions. However, it only formats staged files, so anything in .gitignore is implicitly ignored by lint-staged.

Prettier 3 does take the root .gitignore into account, but it doesn't consider nested .gitignore files, which are being used in this project. I needed to add the VitePress cache to .prettierignore to account for that. Perhaps other files should be added too, but it wasn't clear to me what some of the things in the nested .gitignore files were.

There are also 3 VitePress config files in this PR with minor formatting tweaks. These are files that are now picked up by lint:script that weren't previously. They should have already been picked up by lint-staged, but prior to #2466 that wasn't working for most people.

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit 0c6ccaa
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/67c67dae6c07c8000891fa05
😎 Deploy Preview https://deploy-preview-2470--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 4, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vue-router@2470

commit: 0c6ccaa

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (3753ede) to head (0c6ccaa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2470   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          34       34           
  Lines        2998     2998           
  Branches      845      845           
=======================================
  Hits         2845     2845           
  Misses        150      150           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant