Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory harvester test workflows #28345

Conversation

pereyra-m
Copy link
Member

@pereyra-m pereyra-m commented Feb 20, 2025

Related issue
Closes #27897

Description

This PR fixes the current workflows compilation and adds a new one for inventory harvester module.
The failing tests won't be fixed here.

Also, an integration test was created to verify the test tool properly indexes the events.

@pereyra-m pereyra-m self-assigned this Feb 20, 2025
@pereyra-m pereyra-m changed the base branch from dev/fim-syscollector-global-queries to dev/fim-syscollector-global-queries-tmp February 20, 2025 23:41
@pereyra-m pereyra-m changed the base branch from dev/fim-syscollector-global-queries-tmp to dev/fim-syscollector-global-queries February 21, 2025 00:36
@pereyra-m pereyra-m force-pushed the enhancement/27897-add-inventory-workflows-automation branch from 8ff5bc7 to c526f34 Compare February 21, 2025 00:45
@pereyra-m pereyra-m force-pushed the enhancement/27897-add-inventory-workflows-automation branch 3 times, most recently from 15d4fc1 to a82a360 Compare February 21, 2025 03:01
@pereyra-m pereyra-m force-pushed the enhancement/27897-add-inventory-workflows-automation branch from a82a360 to c72c47b Compare February 21, 2025 03:09
@pereyra-m pereyra-m force-pushed the enhancement/27897-add-inventory-workflows-automation branch from c72c47b to 8087df0 Compare February 21, 2025 04:12
@pereyra-m pereyra-m linked an issue Feb 21, 2025 that may be closed by this pull request
2 tasks
@pereyra-m pereyra-m requested a review from Dwordcito February 22, 2025 03:29
Copy link
Member

@MiguelazoDS MiguelazoDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! some question but I don't think we should delay the merge of this implementation.

- ".github/actions/vulnerability_scanner_deps/action.yml"
- "src/shared_modules/router/**"
- "src/shared_modules/indexer_connector/**"
- "src/wazuh_modules/http-request/**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid directory! probably you try to write inventory_harvester here.

path: src/wazuh_modules/inventory_harvester
id: inventory_harvester

- name: Inventory harvester - Doxygen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove doxygen, we will deprecate this inline documentation in favor of the mdbook.

@@ -0,0 +1,201 @@
name: Inventory Harvester Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new test schema -> Documented in the xdr+siem google site.

@Dwordcito Dwordcito force-pushed the enhancement/27897-add-inventory-workflows-automation branch 3 times, most recently from af0c6ff to 5aeada8 Compare March 9, 2025 12:03
@Dwordcito Dwordcito force-pushed the enhancement/27897-add-inventory-workflows-automation branch from 5aeada8 to db7f32b Compare March 9, 2025 12:09
@Dwordcito Dwordcito closed this Mar 10, 2025
@Dwordcito Dwordcito reopened this Mar 11, 2025
@Dwordcito
Copy link
Member

QA/Integration test will be fixed by #28347

@Dwordcito Dwordcito merged commit ee35d9b into dev/fim-syscollector-global-queries Mar 12, 2025
53 of 58 checks passed
@Dwordcito Dwordcito deleted the enhancement/27897-add-inventory-workflows-automation branch March 12, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inventory workflows automation
3 participants