Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the wait for scrollend / scroll completion timeout for tests that include a smooth scroll #921

Open
dlrobertson opened this issue Feb 11, 2025 · 1 comment
Labels
focus area: scrollend event test-change-proposal Proposal to add or remove tests for an interop area

Comments

@dlrobertson dlrobertson added test-change-proposal Proposal to add or remove tests for an interop area focus area: Scrolling labels Feb 11, 2025
@zcorpan
Copy link
Member

zcorpan commented Feb 17, 2025

The comment above waitFor says

// TODO(crbug.com/1400399): deprecate. We should not use frame based waits in
// WPT as frame rates may vary greatly in different testing environments.

At 60fps, 700 frames is 11.67s. At 120fps, it's 5.83s.

createScrollendPromiseForTarget accepts a timeout argument, which flows through to t.step_timeout() (docs). Could the smooth scroll tests set a longer timeout?

What is the longest duration for a smooth scroll in implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: scrollend event test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

2 participants