-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zstd support #54
Comments
Currently libzstd is not linked into Chromium. It would add roughly 700KB to the binary size (maybe can be trimmed a bit). This would be a hard sell if the compression standard is the only user. |
It seems that you did manage to trim the size a bit as this change only added 38k. Was that just by dropping everything besides decompression, or were there other tricks you made use of? On the storage team we are also interested in using zstd for compressing IndexedDB values before sending them over IPC (or storing as blobs). Adding the compression half of zstd appears to add another 200kB. So that's at least two users of zstd. |
We didn't do anything special in Chromium to reduce the size increase, except for only compiling in the decompression code. I think we were just lucky. I would like to move this specification to WHATWG before we add new features, since it is now implemented in Firefox and Safari and we would like to have consensus. That means it will probably be some months before there's movement on adding zstd. |
Why would it take that much to move to WHATWG? |
Note: Chrome/Chromium, Firefox, and Opera have agreed to add zstd to content-encoding options. Chrome is planning on General Availability in 118. |
Another note: Firefox now supports |
Please add it to the specification, as it seemingly blocks from implementing https://issues.chromium.org/issues/348499728 ![]() |
Just as brotli, we'd be open to ship only DecompressionStream support for zstd, as @jesup reported 600KB size increase to ship the compression side of the library. |
Thanks. I think this will also be Blink's position. |
Bun would be interested in supporting this since we already ship with zstd support internally for other APIs |
I heavily use |
We need someone to write an implementation, a PR to update this specification, and web platform tests. Or three separate people, it doesn't matter. At the last W3C TPAC we reached an agreement in principle to add this to the standard, someone just needs to do the work. Unfortunately Chromium won't be able to ship this until there is some real-world usage, due to the binary size problem. |
Did we? I think we only agreed about brotli. |
@saschanaz My recollection is that we had a proper agreement for Brotli, and someone suggested we apply it to zstd too, and there was a general sense of agreement. However, if you think there's more to be done to get agreement for zstd, I'm happy to wait for that. |
I remember (and per the meeting minutes) I checked again about zstd at the end of the meeting and everyone said brotli only... But maybe I'm wrong? (if others are fine with it, Mozilla would be happy to consider exposing our ongoing zstd implementation) |
Colleagues and I would like to see |
Issue for discussion of adding support for the zstd format to the API.
The text was updated successfully, but these errors were encountered: