-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Color 4 color spaces for canvasGradient #10986
base: main
Are you sure you want to change the base?
Conversation
Can you please restore the PR template? cc @whatwg/canvas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lacks normative definitions for the new attributes.
https://crbug.com/394052224 This cannot be opened by non-Google internal users. |
Sorry! I believe I have fixed this. |
Done! |
Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255}
Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255}
Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255}
Just added some basic ones. Do we need to define the color spaces themselves? premultipliedAlpha is defined elsewhere in this document, but color interpolation spaces are only defined pretty tersely: https://html.spec.whatwg.org/#colour-spaces-and-colour-correction And hue interpolation does appear to be defined at all. Should my normative definitions cite CSS? Or do we need separate definitions here. |
I think it's okay if some aspects are a bit hand-wavy, but ideally they are not or at least done in such a way that we can gradually fill out the details over time. If concepts are shared with CSS it would be good to reference CSS. Perhaps some kind of shared abstraction is in order. We have done this for other features that are shared with CSS as well. |
…asGradient, a=testonly Automatic update from web-platform-tests Add CSS Color 4 gradient options to CanvasGradient Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255} -- wpt-commits: fa9792e79e03bcdb6ce8a913c74981cbebe77756 wpt-pr: 50878
…asGradient, a=testonly Automatic update from web-platform-tests Add CSS Color 4 gradient options to CanvasGradient Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255} -- wpt-commits: fa9792e79e03bcdb6ce8a913c74981cbebe77756 wpt-pr: 50878
…asGradient, a=testonly Automatic update from web-platform-tests Add CSS Color 4 gradient options to CanvasGradient Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Aaron Krajeski <aaronhkchromium.org> Cr-Commit-Position: refs/heads/main{#1423255} -- wpt-commits: fa9792e79e03bcdb6ce8a913c74981cbebe77756 wpt-pr: 50878 UltraBlame original commit: f95ce76846e9f8b4d9cce5a7926d6b2778608be2
…asGradient, a=testonly Automatic update from web-platform-tests Add CSS Color 4 gradient options to CanvasGradient Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Aaron Krajeski <aaronhkchromium.org> Cr-Commit-Position: refs/heads/main{#1423255} -- wpt-commits: fa9792e79e03bcdb6ce8a913c74981cbebe77756 wpt-pr: 50878 UltraBlame original commit: f95ce76846e9f8b4d9cce5a7926d6b2778608be2
…asGradient, a=testonly Automatic update from web-platform-tests Add CSS Color 4 gradient options to CanvasGradient Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Aaron Krajeski <aaronhkchromium.org> Cr-Commit-Position: refs/heads/main{#1423255} -- wpt-commits: fa9792e79e03bcdb6ce8a913c74981cbebe77756 wpt-pr: 50878 UltraBlame original commit: f95ce76846e9f8b4d9cce5a7926d6b2778608be2
…asGradient, a=testonly Automatic update from web-platform-tests Add CSS Color 4 gradient options to CanvasGradient Add ColorInterpolationMethod, HueInterpolationMethod and premultipliedAlpha attributes to CanvasGradient as described here: whatwg/html#7947 This is done behind the flag CanvasGradientCSSColor4, as spec is not yet settled: whatwg/html#10986 Chromestatus: https://chromestatus.com/feature/5168382242193408 I2P thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/6PhsIK2kxeM Gradient::ColorInterpolation is also renamed to Gradient::PremultipliedAlpha, because that's what it is. Subpixel antialiasing for test labels is being inconsistently applied on windows, so the tests are marked as failing with a bug. crbug.com/396344375 Bug: 394052224 Change-Id: I6b1092376d08c051b161f83c82d585bd03cd4131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226021 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423255} -- wpt-commits: fa9792e79e03bcdb6ce8a913c74981cbebe77756 wpt-pr: 50878
Add ColorInterpolationMethod, HueInterpolationMethod and premultiplyAlpha attributes to CanvasGradient.
At least two implementers are interested (and none opposed):
Tests are written and can be reviewed and commented upon.
Implementation bugs are filed:
Corresponding HTML AAM & ARIA in HTML issues & PRs:
MDN issue is filed: …
The top of this comment includes a clear commit message to use.
Open questions:
TODO:
/canvas.html ( diff )