Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebDriver BiDi interception in the show file picker algorithm #11030

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

sadym-chromium
Copy link

@sadym-chromium sadym-chromium commented Feb 14, 2025

Implement WebDriver BiDi interception in the show file picker algorithm.

(See WHATWG Working Mode: Changes for more details.)

Re-create #9844


/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )

@sadym-chromium sadym-chromium changed the title [WIP] Implement WebDriver BiDi interception in the show the picker algorithm [WIP] Implement WebDriver BiDi interception in the show file picker algorithm Feb 25, 2025
@sadym-chromium sadym-chromium changed the title [WIP] Implement WebDriver BiDi interception in the show file picker algorithm Implement WebDriver BiDi interception in the show file picker algorithm Feb 25, 2025
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % description of the issue might need updates

@sadym-chromium sadym-chromium changed the title Implement WebDriver BiDi interception in the show file picker algorithm Implement WebDriver BiDi interception in the show picker algorithm Mar 4, 2025
@sadym-chromium sadym-chromium changed the title Implement WebDriver BiDi interception in the show picker algorithm [WIP] Implement WebDriver BiDi interception in the show picker algorithm Mar 4, 2025
@sadym-chromium sadym-chromium force-pushed the sadym/update-file-spec branch from f11d815 to 60b2e31 Compare March 4, 2025 13:14
@sadym-chromium sadym-chromium force-pushed the sadym/update-file-spec branch from 60b2e31 to 2ea78f5 Compare March 4, 2025 13:16
sadym-chromium added a commit to w3c/webdriver-bidi that referenced this pull request Mar 5, 2025
This PR implements `input.fileDialogOpened` event and defines `unhandledPromptBehavior` for `file`. It should be accompanied by the following changes:
HTML spec: whatwg/html#11030
WebDriver Classic spec: w3c/webdriver#1884
File system access: WICG/file-system-access#452
@sadym-chromium sadym-chromium changed the title [WIP] Implement WebDriver BiDi interception in the show picker algorithm Implement WebDriver BiDi interception in the show file picker algorithm Mar 5, 2025
@sadym-chromium sadym-chromium requested a review from OrKoN March 5, 2025 14:59
@sadym-chromium sadym-chromium marked this pull request as ready for review March 5, 2025 16:15
@sadym-chromium
Copy link
Author

@domenic could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants