-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WebDriver BiDi interception in the show file picker algorithm #11030
Open
sadym-chromium
wants to merge
14
commits into
whatwg:main
Choose a base branch
from
sadym-chromium:sadym/update-file-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement WebDriver BiDi interception in the show file picker algorithm #11030
sadym-chromium
wants to merge
14
commits into
whatwg:main
from
sadym-chromium:sadym/update-file-spec
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9694ffa
to
091fe90
Compare
OrKoN
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % description of the issue might need updates
f11d815
to
60b2e31
Compare
60b2e31
to
2ea78f5
Compare
sadym-chromium
added a commit
to w3c/webdriver-bidi
that referenced
this pull request
Mar 5, 2025
This PR implements `input.fileDialogOpened` event and defines `unhandledPromptBehavior` for `file`. It should be accompanied by the following changes: HTML spec: whatwg/html#11030 WebDriver Classic spec: w3c/webdriver#1884 File system access: WICG/file-system-access#452
@domenic could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement WebDriver BiDi interception in the show file picker algorithm.
input.fileDialogOpened
.input.fileDialogOpened
+unhandledPromptBehavior:file
GoogleChromeLabs/chromium-bidi#3187(See WHATWG Working Mode: Changes for more details.)
Re-create #9844
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )