Change focus delegate for dialog to use flat tree to find focusable descendant #11088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Mar 3, 2025
There was a problem hiding this comment.
In addition to the inline comments, I think this has a few other issues:
- This only handles dialogs, whereas I thought we wanted to handle popovers as well (per Focus delegate algorithm doesn't consider elements assigned to slot #9245 (comment))?
- Because this checks whereToLook instead of focusTarget, I think it does the wrong thing for dialogs that are shadow hosts. (Since shadow roots are never dialog elements).
- Because we already have two special cases in this algorithm for focusTarget being a dialog element (step 6.2 and 6.3), and this is adding a third, I think we've reached the point where having a separate "dialog initial focus delegate" algorithm would be better than reusing the same one with branching. (Or maybe "dialog/popover initial focus delegate"?)
| <li> | ||
| <p>If <var>whereToLook</var> is a <code>dialog</code>, let <var>treeOrder</var> be the | ||
| <span>flat tree</span>. Otherwise, let <var>treeOrder</var> be <span>tree order</span>.</p> | ||
| </li> |
There was a problem hiding this comment.
Here and below, format single-paragraph list items as <li><p>...</p></li>, without extra linebreaks/whitespace around the start/end tags. (Matching nearby style.)
| <var>whereToLook</var>'s <span data-x="descendant">descendants</span>, in <span>tree | ||
| order</span>:</p> | ||
| <var>whereToLook</var>'s <span data-x="descendant">descendants</span>, in | ||
| <var>treeOrder</var>:</p> |
There was a problem hiding this comment.
I don't think this is correct. We don't want to always look at the DOM tree descendants, just changing the order. We want to look at the flat tree descendants, which are different than the DOM tree descendants. (IIUC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
/interaction.html ( diff )