Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commands] Add Subsystem.idle() #7815

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[commands] Add Subsystem.idle() #7815

wants to merge 4 commits into from
+22 −0

Conversation

WispySparks
Copy link
Contributor

No description provided.

@WispySparks WispySparks requested a review from a team as a code owner February 23, 2025 06:23
@github-actions GitHub Actions
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@github-actions github-actions bot added the component: command-based WPILib Command Based Library label Feb 23, 2025
KangarooKoala
KangarooKoala approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for what it's worth. You might want to move it above runOnce() though to make the order match better with Commands.java and Commands.h.

@WispySparks WispySparks mentioned this pull request Feb 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: command-based WPILib Command Based Library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WispySparks @KangarooKoala