Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpimath] Fix singularities in Ellipse2d::Nearest() #7851

Conversation

calcmogul
Copy link
Member

The problem was ill-conditioned if either semiaxis had zero length.

@calcmogul calcmogul requested a review from a team as a code owner March 4, 2025 00:02
@github-actions github-actions bot added the component: wpimath Math library label Mar 4, 2025
PeterJohnson
PeterJohnson previously approved these changes Mar 4, 2025
The problem was ill-conditioned if either semiaxis had zero length.
@calcmogul calcmogul force-pushed the wpimath-fix-singularities-in-ellipse2d-nearest branch from 0f86162 to 68a7c35 Compare March 4, 2025 00:04
@PeterJohnson PeterJohnson merged commit 1a835fe into wpilibsuite:main Mar 5, 2025
47 checks passed
@calcmogul calcmogul deleted the wpimath-fix-singularities-in-ellipse2d-nearest branch March 5, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants