Temporary workaround for "subtree" checkout errors on Windows #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts. This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run. In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream. b/282361986
kaidokert
force-pushed
the
workaround_checkouts
branch
from
cd3e8d0 to
5f1b187
Compare
isarkis
approved these changes
May 16, 2023
briantting
approved these changes
May 16, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
May 16, 2023
This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts. This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run. In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream. Upstream PR: actions/checkout#1321 b/282361986 b/258687270 (cherry picked from commit 3c24834)
kaidokert
added a commit
that referenced
this pull request
May 16, 2023
…386) This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts. This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run. In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream. Upstream PR: actions/checkout#1321 b/282361986 b/258687270 (cherry picked from commit 3c24834) Co-authored-by: Kert <kaidokert@google.com>
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
May 18, 2023
This uses the patched workaround version of checkout action to sidestep submodules issues. In original PR youtube#383 we only fixed Windows workflows that had issues due to peristent runners, but similar problems also trip on Linux/other builds. b/282361986
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
May 18, 2023
This uses the patched workaround version of checkout action to sidestep submodules issues. In original PR youtube#383 we only fixed Windows workflows that had issues due to persistent runners, but similar problems also trip on Linux/other builds. b/282361986
kaidokert
added a commit
that referenced
this pull request
May 18, 2023
This uses the patched workaround version of checkout action to sidestep submodules issues. In original PR #383 we only fixed Windows workflows that had issues due to persistent runners, but similar problems also trip on Linux/other builds. b/282361986
sherryzy
pushed a commit
to sherryzy/cobalt
that referenced
this pull request
May 18, 2023
This uses the patched workaround version of checkout action to sidestep submodules issues. In original PR youtube#383 we only fixed Windows workflows that had issues due to persistent runners, but similar problems also trip on Linux/other builds. b/282361986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts.
This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run.
In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream.
Upstream PR: actions/checkout#1321
b/282361986
b/258687270