Merge node 12.19.0

Merges the changes from the node v12.19.0 release into nodejs-mobile.

Author: jaimecbernardo

.eslintrc.js

@@ -59,7 +59,7 @@ module.exports = {
   ],
   rules: {
     // ESLint built-in rules
-    // http://eslint.org/docs/rules
+    // https://eslint.org/docs/rules/
     'accessor-pairs': 'error',
     'array-callback-return': 'error',
     'arrow-parens': ['error', 'always'],
@@ -129,6 +129,7 @@ module.exports = {
     'no-dupe-else-if': 'error',
     'no-duplicate-case': 'error',
     'no-duplicate-imports': 'error',
+    'no-else-return': ['error', { allowElseIf: true }],
     'no-empty-character-class': 'error',
     'no-ex-assign': 'error',
     'no-extra-boolean-cast': 'error',
@@ -189,34 +190,6 @@ module.exports = {
     // as well to lib/.eslintrc.yaml.
     'no-restricted-syntax': [
       'error',
-      {
-        selector: "CallExpression[callee.property.name='deepStrictEqual'][arguments.2.type='Literal']",
-        message: 'Do not use a literal for the third argument of assert.deepStrictEqual()',
-      },
-      {
-        selector: "CallExpression[callee.property.name='doesNotThrow']",
-        message: 'Do not use `assert.doesNotThrow()`. Write the code without the wrapper and add a comment instead.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='doesNotReject']",
-        message: 'Do not use `assert.doesNotReject()`. Write the code without the wrapper and add a comment instead.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='rejects'][arguments.length<2]",
-        message: '`assert.rejects()` must be invoked with at least two arguments.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='strictEqual'][arguments.2.type='Literal']",
-        message: 'Do not use a literal for the third argument of assert.strictEqual()',
-      },
-      {
-        selector: "CallExpression[callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
-        message: 'Use an object as second argument of `assert.throws()`.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='throws'][arguments.length<2]",
-        message: '`assert.throws()` must be invoked with at least two arguments.',
-      },
       {
         selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
         message: '`setTimeout()` must be invoked with at least two arguments.',
@@ -229,22 +202,6 @@ module.exports = {
         selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]',
         message: 'Use `new` keyword when throwing an `Error`.',
       },
-      {
-        selector: "CallExpression[callee.property.name='notDeepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='notStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='deepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
       {
         selector: "CallExpression[callee.name='isNaN']",
         message: 'Use Number.isNaN() instead of the global isNaN() function.',

.github/CODEOWNERS

@@ -0,0 +1,101 @@
+# Node.js Project Codeowners
+
+# 1. Codeowners must always be teams, never individuals
+# 2. Each codeowner team should contain at least one TSC member
+# 3. PRs touching any code with a codeowner must be signed off by at least one
+#    person on the code owner team.
+
+# tsc & commcomm
+
+/.github/CODEOWNERS @nodejs/tsc
+/GOVERNANCE.md @nodejs/tsc
+/onboarding.md @nodejs/tsc
+/CODE_OF_CONDUCT.md @nodejs/tsc @nodejs/community-committee
+/CONTRIBUTING.md @nodejs/tsc @nodejs/community-committee
+/LICENSE @nodejs/tsc @nodejs/community-committee
+/doc/guides/contributing/code-of-conduct.md @nodejs/tsc @nodejs/community-committee
+# TODO(mmarchini): the bot doens't have a notion of precedence, that might
+# change when move the codeowners code to an Action, at which point we can
+# uncomment the line below
+# /doc/guides/contributing/*.md @nodejs/tsc
+/doc/guides/contributing/issues.md @nodejs/tsc
+/doc/guides/contributing/pull-requests.md @nodejs/tsc
+/doc/guides/collaborator-guide.md @nodejs/tsc
+/doc/guides/offboarding.md @nodejs/tsc
+/doc/guides/onboarding-extras.md @nodejs/tsc
+
+# net
+
+/deps/cares @nodejs/net
+/doc/api/dns.md @nodejs/net
+/doc/api/dgram.md @nodejs/net
+/doc/api/net.md @nodejs/net
+/lib/dgram.js @nodejs/net
+/lib/dns.js @nodejs/net
+/lib/net.js @nodejs/net @nodejs/quic
+/lib/internal/dgram.js @nodejs/net
+/lib/internal/dns/* @nodejs/net
+/lib/internal/net.js @nodejs/net
+/lib/internal/socket_list.js @nodejs/net
+/lib/internal/js_stream_socket.js @nodejs/net
+/src/cares_wrap.h @nodejs/net
+/src/connect_wrap.* @nodejs/net
+/src/connection_wrap.* @nodejs/net
+/src/node_sockaddr* @nodejs/net
+/src/tcp_wrap.* @nodejs/net
+/src/udp_wrap.* @nodejs/net
+
+# tls/crypto
+
+/lib/internal/crypto/* @nodejs/crypto
+/lib/internal/tls.js @nodejs/crypto @nodejs/net
+/lib/crypto.js @nodejs/crypto
+/lib/tls.js @nodejs/crypto @nodejs/net
+/src/node_crypto* @nodejs/crypto
+/src/node_crypto_common* @nodejs/crypto @nodejs/quic
+
+# http
+
+/deps/llhttp/* @nodejs/http @nodejs/net
+/doc/api/http.md @nodejs/http @nodejs/net
+/doc/api/http2.md @nodejs/http @nodejs/net
+/lib/_http_* @nodejs/http @nodejs/net
+/lib/http.js @nodejs/http @nodejs/net
+/lib/https.js @nodejs/crypto @nodejs/net @nodejs/http
+/src/node_http_common* @nodejs/http @nodejs/http2 @nodejs/quic @nodejs/net
+/src/node_http_parser.cc @nodejs/http @nodejs/net
+
+# http2
+
+/deps/nghttp2/* @nodejs/http2 @nodejs/net
+/doc/api/http2.md @nodejs/http2 @nodejs/net
+/lib/http2.js @nodejs/http2 @nodejs/net
+/lib/internal/http2/* @nodejs/http2 @nodejs/net
+/src/node_http2* @nodejs/http2 @nodejs/net
+/src/node_mem* @nodejs/http2
+
+# modules
+
+/doc/api/modules.md @nodejs/modules
+/doc/api/esm.md @nodejs/modules
+/doc/api/module.md @nodejs/modules
+/doc/api/packages.md @nodejs/modules
+/lib/module.js @nodejs/modules
+/lib/internal/modules/* @nodejs/modules
+/lib/internal/bootstrap/loaders.js @nodejs/modules
+/src/module_wrap* @nodejs/modules @nodejs/vm
+
+# N-API
+
+/src/node_api* @nodejs/n-api
+/src/js_native_api* @nodejs/n-api
+/doc/guides/adding-new-napi-api.md @nodejs/n-api
+/doc/api/n-api.md @nodejs/n-api
+
+# WASI
+/deps/uvwasi/ @nodejs/wasi
+/doc/api/wasi.md @nodejs/wasi
+/lib/wasi.js @nodejs/wasi
+/src/node_wasi* @nodejs/wasi
+/test/wasi/ @nodejs/wasi
+/test/fixtures/wasi/ @nodejs/wasi

.github/ISSUE_TEMPLATE/3-api-ref-docs-problem.md

@@ -0,0 +1,77 @@
+---
+name: "\U0001F4D7 Open an issue regarding the Node.js API reference docs"
+about: Let us know about any problematic API reference documents
+title: "doc: "
+labels: doc
+---
+
+# 📗 API Reference Docs Problem
+
+<!--
+
+Thank you for wanting to make nodejs.org better!
+
+This template is for issues with the Node.js API
+reference documentation.
+
+For problems with nodejs.org beyond the API
+reference documentation, please open an issue
+using the issue tracker for our site repository.
+
+  https://github.com/nodejs/nodejs.org
+
+For more general support, please open an issue
+using the issue tracker for our help repository.
+
+  https://github.com/nodejs/help
+
+---
+
+For the issue title, please enter a one-line
+summary after “doc: ” (preferably 50 characters
+or less and no more than 72).
+
+The “✍️” are placeholders signifying requests for
+input. Replace them with your responses.
+
+If you are unsure of something, do your best.
+
+-->
+
+<!-- The output of “node --version”. -->
+
+- **Version**: ✍️
+
+<!-- The output of “uname -a” (UNIX) or version
+and 32-bit or 64-bit (Windows). -->
+
+- **Platform**: ✍️
+
+<!-- The name of affected core module. -->
+
+- **Subsystem**: ✍️
+
+## Location
+
+_Section of the site where the content exists_
+
+Affected URL(s):
+
+- https://nodejs.org/api/✍️
+
+## Description
+
+_Concise explanation of the problem_
+
+<!-- If applicable, include any screenshots that
+may help solve the problem. -->
+
+✍️
+
+---
+
+<!-- Use “[x]” to check the box below if you are
+interested in contributing. -->
+
+- [ ] I would like to work on this issue and
+      submit a pull request.

.github/ISSUE_TEMPLATE/4-report-a-flaky-test.md

@@ -0,0 +1,34 @@
+---
+name: Report a flaky test
+about: Report a flaky test in our CI
+labels: "CI / flaky test"
+
+---
+
+<!--
+Thank you for reporting a flaky test.
+
+Flaky tests are tests that fail occasionally in the Node.js CI, but not
+consistently enough to block PRs from landing, or that are failing in CI jobs or
+test modes that are not run for every PR.
+
+Please fill in as much of the template below as you're able.
+
+Test: The test that is flaky - e.g. `test-fs-stat-bigint`
+Platform: The platform the test is flaky on - e.g. `macos` or `linux`
+Console Output: A pasted console output from a failed CI job showing the whole
+failure of the test
+Build Links: Links to builds affected by the flaky test
+
+If any investigation has been done, please include any information found, such
+as how consistently the test fails, whether the failure could be reproduced
+locally, when the test started failing, or anything else you think is relevant.
+-->
+
+* **Test**:
+* **Platform**:
+* **Console Output:**
+```
+REPLACE ME
+```
+* **Build Links**:

.github/workflows/auto-start-ci.yml

@@ -0,0 +1,63 @@
+---
+name: Auto Start CI
+
+on:
+  schedule:
+    # Runs every five minutes (fastest the scheduler can run). Five minutes is
+    # optimistic, it can take longer to run.
+    # To understand why `schedule` is used instead of other events, refer to
+    # ./doc/guides/commit-queue.md
+    - cron: "*/5 * * * *"
+
+jobs:
+  startCI:
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@master
+
+      # Install dependencies
+      - name: Install jq
+        run: sudo apt-get install jq -y
+      - name: Install Node.js
+        uses: actions/setup-node@v2-beta
+        with:
+          node-version: '12'
+      - name: Install node-core-utils
+        run: npm install -g node-core-utils
+
+      - name: Set variables
+        run: |
+          echo "::set-env name=REPOSITORY::$(echo ${{ github.repository }} | cut -d/ -f2)"
+          echo "::set-env name=OWNER::${{ github.repository_owner }}"
+
+      # Get Pull Requests
+      - name: Get Pull Requests
+        uses: octokit/graphql-action@v2.x
+        id: get_prs_for_ci
+        with:
+          query: |
+            query prs($owner:String!, $repo:String!) {
+              repository(owner:$owner, name:$repo) {
+                pullRequests(labels: ["request-ci"], states: OPEN, last: 100) {
+                  nodes {
+                    number
+                  }
+                }
+              }
+            }
+          owner: ${{ env.OWNER }}
+          repo: ${{ env.REPOSITORY }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Setup node-core-utils
+        run: |
+          ncu-config set username ${{ secrets.JENKINS_USER }}
+          ncu-config set token none
+          ncu-config set jenkins_token ${{ secrets.JENKINS_TOKEN }}
+          ncu-config set owner ${{ env.OWNER }}
+          ncu-config set repo ${{ env.REPOSITORY }}
+
+      - name: Start CI
+        run: ./tools/actions/start-ci.sh ${{ secrets.GITHUB_TOKEN }} ${{ env.OWNER }} ${{ env.REPOSITORY }} $(echo '${{ steps.get_prs_for_ci.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')

.github/workflows/close-stalled.yml

@@ -0,0 +1,25 @@
+name: Close stalled issues and PRs
+on:
+  schedule:
+  - cron: "0 0 * * *"
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/stale@v3
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        days-before-close: 30
+        stale-pr-label: stalled
+        stale-issue-label: stalled
+        close-issue-message: Closing this because it has stalled. Feel free to reopen if this issue is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
+        close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
+        # used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues
+        only-labels: stalled
+        # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
+        operations-per-run: 500
+        # deactivates automatic removal of stalled label if issue gets any activity
+        remove-stale-when-updated: false
+        # deactivates automatic stale labelling as we prefer to do that manually
+        days-before-stale: -1