Merge node 12.19.0

Merges the changes from the node v12.19.0 release into nodejs-mobile.

Author: jaimecbernardo

.eslintrc.js

@@ -59,7 +59,7 @@ module.exports = {
   ],
   rules: {
     // ESLint built-in rules
-    // http://eslint.org/docs/rules
+    // https://eslint.org/docs/rules/
     'accessor-pairs': 'error',
     'array-callback-return': 'error',
     'arrow-parens': ['error', 'always'],
@@ -129,6 +129,7 @@ module.exports = {
     'no-dupe-else-if': 'error',
     'no-duplicate-case': 'error',
     'no-duplicate-imports': 'error',
+    'no-else-return': ['error', { allowElseIf: true }],
     'no-empty-character-class': 'error',
     'no-ex-assign': 'error',
     'no-extra-boolean-cast': 'error',
@@ -189,34 +190,6 @@ module.exports = {
     // as well to lib/.eslintrc.yaml.
     'no-restricted-syntax': [
       'error',
-      {
-        selector: "CallExpression[callee.property.name='deepStrictEqual'][arguments.2.type='Literal']",
-        message: 'Do not use a literal for the third argument of assert.deepStrictEqual()',
-      },
-      {
-        selector: "CallExpression[callee.property.name='doesNotThrow']",
-        message: 'Do not use `assert.doesNotThrow()`. Write the code without the wrapper and add a comment instead.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='doesNotReject']",
-        message: 'Do not use `assert.doesNotReject()`. Write the code without the wrapper and add a comment instead.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='rejects'][arguments.length<2]",
-        message: '`assert.rejects()` must be invoked with at least two arguments.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='strictEqual'][arguments.2.type='Literal']",
-        message: 'Do not use a literal for the third argument of assert.strictEqual()',
-      },
-      {
-        selector: "CallExpression[callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
-        message: 'Use an object as second argument of `assert.throws()`.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='throws'][arguments.length<2]",
-        message: '`assert.throws()` must be invoked with at least two arguments.',
-      },
       {
         selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
         message: '`setTimeout()` must be invoked with at least two arguments.',
@@ -229,22 +202,6 @@ module.exports = {
         selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]',
         message: 'Use `new` keyword when throwing an `Error`.',
       },
-      {
-        selector: "CallExpression[callee.property.name='notDeepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='notStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='deepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
-      {
-        selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
-        message: 'The first argument should be the `actual`, not the `expected` value.',
-      },
       {
         selector: "CallExpression[callee.name='isNaN']",
         message: 'Use Number.isNaN() instead of the global isNaN() function.',

.github/CODEOWNERS

@@ -0,0 +1,101 @@
+# Node.js Project Codeowners
+
+# 1. Codeowners must always be teams, never individuals
+# 2. Each codeowner team should contain at least one TSC member
+# 3. PRs touching any code with a codeowner must be signed off by at least one
+#    person on the code owner team.
+
+# tsc & commcomm
+
+/.github/CODEOWNERS @nodejs/tsc
+/GOVERNANCE.md @nodejs/tsc
+/onboarding.md @nodejs/tsc
+/CODE_OF_CONDUCT.md @nodejs/tsc @nodejs/community-committee
+/CONTRIBUTING.md @nodejs/tsc @nodejs/community-committee
+/LICENSE @nodejs/tsc @nodejs/community-committee
+/doc/guides/contributing/code-of-conduct.md @nodejs/tsc @nodejs/community-committee
+# TODO(mmarchini): the bot doens't have a notion of precedence, that might
+# change when move the codeowners code to an Action, at which point we can
+# uncomment the line below
+# /doc/guides/contributing/*.md @nodejs/tsc
+/doc/guides/contributing/issues.md @nodejs/tsc
+/doc/guides/contributing/pull-requests.md @nodejs/tsc
+/doc/guides/collaborator-guide.md @nodejs/tsc
+/doc/guides/offboarding.md @nodejs/tsc
+/doc/guides/onboarding-extras.md @nodejs/tsc
+
+# net
+
+/deps/cares @nodejs/net
+/doc/api/dns.md @nodejs/net
+/doc/api/dgram.md @nodejs/net
+/doc/api/net.md @nodejs/net
+/lib/dgram.js @nodejs/net
+/lib/dns.js @nodejs/net
+/lib/net.js @nodejs/net @nodejs/quic
+/lib/internal/dgram.js @nodejs/net
+/lib/internal/dns/* @nodejs/net
+/lib/internal/net.js @nodejs/net
+/lib/internal/socket_list.js @nodejs/net
+/lib/internal/js_stream_socket.js @nodejs/net
+/src/cares_wrap.h @nodejs/net
+/src/connect_wrap.* @nodejs/net
+/src/connection_wrap.* @nodejs/net
+/src/node_sockaddr* @nodejs/net
+/src/tcp_wrap.* @nodejs/net
+/src/udp_wrap.* @nodejs/net
+
+# tls/crypto
+
+/lib/internal/crypto/* @nodejs/crypto
+/lib/internal/tls.js @nodejs/crypto @nodejs/net
+/lib/crypto.js @nodejs/crypto
+/lib/tls.js @nodejs/crypto @nodejs/net
+/src/node_crypto* @nodejs/crypto
+/src/node_crypto_common* @nodejs/crypto @nodejs/quic
+
+# http
+
+/deps/llhttp/* @nodejs/http @nodejs/net
+/doc/api/http.md @nodejs/http @nodejs/net
+/doc/api/http2.md @nodejs/http @nodejs/net
+/lib/_http_* @nodejs/http @nodejs/net
+/lib/http.js @nodejs/http @nodejs/net
+/lib/https.js @nodejs/crypto @nodejs/net @nodejs/http
+/src/node_http_common* @nodejs/http @nodejs/http2 @nodejs/quic @nodejs/net
+/src/node_http_parser.cc @nodejs/http @nodejs/net
+
+# http2
+
+/deps/nghttp2/* @nodejs/http2 @nodejs/net
+/doc/api/http2.md @nodejs/http2 @nodejs/net
+/lib/http2.js @nodejs/http2 @nodejs/net
+/lib/internal/http2/* @nodejs/http2 @nodejs/net
+/src/node_http2* @nodejs/http2 @nodejs/net
+/src/node_mem* @nodejs/http2
+
+# modules
+
+/doc/api/modules.md @nodejs/modules
+/doc/api/esm.md @nodejs/modules
+/doc/api/module.md @nodejs/modules
+/doc/api/packages.md @nodejs/modules
+/lib/module.js @nodejs/modules
+/lib/internal/modules/* @nodejs/modules
+/lib/internal/bootstrap/loaders.js @nodejs/modules
+/src/module_wrap* @nodejs/modules @nodejs/vm
+
+# N-API
+
+/src/node_api* @nodejs/n-api
+/src/js_native_api* @nodejs/n-api
+/doc/guides/adding-new-napi-api.md @nodejs/n-api
+/doc/api/n-api.md @nodejs/n-api
+
+# WASI
+/deps/uvwasi/ @nodejs/wasi
+/doc/api/wasi.md @nodejs/wasi
+/lib/wasi.js @nodejs/wasi
+/src/node_wasi* @nodejs/wasi
+/test/wasi/ @nodejs/wasi
+/test/fixtures/wasi/ @nodejs/wasi