Skip to content

Commit a9cee0f

Browse files
committedAug 23, 2021
Delete redundant Left/Right layout attributes
now that we are targeting API higher than 17.
1 parent 83d615e commit a9cee0f

16 files changed

+3
-59
lines changed
 

‎app/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ android {
2727
applicationId 'ee.ioc.phon.android.speak'
2828
minSdkVersion 21
2929
targetSdkVersion 30
30-
versionCode 1806
31-
versionName '1.8.06'
30+
versionCode 1807
31+
versionName '1.8.07'
3232
vectorDrawables.useSupportLibrary = true
3333
// Keep only en and et resources
3434
resConfigs "en", "et"

‎app/src/main/res/layout-land/voice_ime_view.xml

-11
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,11 @@
2727
android:layout_width="wrap_content"
2828
android:layout_height="wrap_content"
2929
android:layout_alignParentStart="true"
30-
android:layout_alignParentLeft="true"
3130
android:layout_alignParentTop="true"
3231
android:background="@drawable/button_go"
3332
android:contentDescription="@string/cdChangeInputMethod"
3433
android:padding="@dimen/layoutMargin1"
3534
android:paddingEnd="@dimen/layoutMargin2"
36-
android:paddingRight="@dimen/layoutMargin2"
3735
android:paddingBottom="@dimen/layoutMargin2"
3836
app:srcCompat="@drawable/ic_ime" />
3937

@@ -59,9 +57,7 @@
5957
android:layout_height="wrap_content"
6058
android:layout_alignParentTop="true"
6159
android:layout_toStartOf="@+id/bImeAction"
62-
android:layout_toLeftOf="@+id/bImeAction"
6360
android:layout_toEndOf="@+id/bImeKeyboard"
64-
android:layout_toRightOf="@+id/bImeKeyboard"
6561
android:ellipsize="start"
6662
android:padding="@dimen/layoutMargin1"
6763
android:singleLine="true"
@@ -75,12 +71,10 @@
7571
android:layout_height="wrap_content"
7672
android:layout_alignParentTop="true"
7773
android:layout_alignParentEnd="true"
78-
android:layout_alignParentRight="true"
7974
android:background="@drawable/button_go"
8075
android:contentDescription="@string/cdGo"
8176
android:padding="@dimen/layoutMargin1"
8277
android:paddingStart="@dimen/layoutMargin2"
83-
android:paddingLeft="@dimen/layoutMargin2"
8478
android:paddingBottom="@dimen/layoutMargin2"
8579
app:srcCompat="@drawable/ic_search" />
8680

@@ -102,7 +96,6 @@
10296
android:layout_height="wrap_content"
10397
android:layout_gravity="end"
10498
android:layout_toStartOf="@+id/bImeAction"
105-
android:layout_toLeftOf="@+id/bImeAction"
10699
android:clipChildren="false"
107100
android:clipToPadding="false"
108101
android:elevation="2dp"
@@ -125,7 +118,6 @@
125118
android:layout_height="@dimen/layoutHeightButtonMicrophoneIme"
126119
android:layout_alignParentTop="true"
127120
android:layout_toEndOf="@+id/tvInstruction"
128-
android:layout_toRightOf="@+id/tvInstruction"
129121
android:background="@drawable/button_mic"
130122
android:contentDescription="@string/cdMicrophone"
131123
android:elevation="6dp"
@@ -137,9 +129,7 @@
137129
android:layout_height="wrap_content"
138130
android:layout_centerVertical="true"
139131
android:layout_marginStart="@dimen/layoutMargin1"
140-
android:layout_marginLeft="@dimen/layoutMargin1"
141132
android:layout_toEndOf="@+id/bImeStartStop"
142-
android:layout_toRightOf="@+id/bImeStartStop"
143133
android:orientation="vertical">
144134

145135
<ImageButton
@@ -151,7 +141,6 @@
151141
android:padding="@dimen/layoutMargin2"
152142
android:paddingTop="@dimen/layoutMargin3"
153143
android:paddingEnd="@dimen/layoutMargin3"
154-
android:paddingRight="@dimen/layoutMargin3"
155144
android:paddingBottom="@dimen/layoutMargin3"
156145
app:srcCompat="@drawable/ic_backspace" />
157146
</LinearLayout>

‎app/src/main/res/layout-watch/recognition_service_ws_url.xml

-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
android:layout_width="wrap_content"
7878
android:layout_height="wrap_content"
7979
android:layout_marginEnd="@dimen/layoutMargin4dp"
80-
android:layout_marginRight="@dimen/layoutMargin4dp"
8180
android:digits="0123456789."
8281
android:hint="@string/hintLocalServer"
8382
android:imeOptions="actionDone"

‎app/src/main/res/layout-watch/voice_ime_view.xml

-8
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,11 @@
2424
android:layout_width="wrap_content"
2525
android:layout_height="wrap_content"
2626
android:layout_alignParentStart="true"
27-
android:layout_alignParentLeft="true"
2827
android:layout_alignParentTop="true"
2928
android:background="@drawable/button_go"
3029
android:contentDescription="@string/cdChangeInputMethod"
3130
android:padding="@dimen/layoutMargin1"
3231
android:paddingEnd="@dimen/layoutMargin2"
33-
android:paddingRight="@dimen/layoutMargin2"
3432
android:paddingBottom="@dimen/layoutMargin2"
3533
app:srcCompat="@drawable/ic_ime" />
3634

@@ -59,9 +57,7 @@
5957
android:layout_centerVertical="true"
6058
android:layout_margin="@dimen/layoutMargin4dp"
6159
android:layout_toStartOf="@+id/bImeAction"
62-
android:layout_toLeftOf="@+id/bImeAction"
6360
android:layout_toEndOf="@+id/bImeKeyboard"
64-
android:layout_toRightOf="@+id/bImeKeyboard"
6561
android:ellipsize="start"
6662
android:gravity="center"
6763
android:singleLine="true"
@@ -75,12 +71,10 @@
7571
android:layout_height="wrap_content"
7672
android:layout_alignParentTop="true"
7773
android:layout_alignParentEnd="true"
78-
android:layout_alignParentRight="true"
7974
android:background="@drawable/button_go"
8075
android:contentDescription="@string/cdGo"
8176
android:padding="@dimen/layoutMargin1"
8277
android:paddingStart="@dimen/layoutMargin2"
83-
android:paddingLeft="@dimen/layoutMargin2"
8478
android:paddingBottom="@dimen/layoutMargin2"
8579
app:srcCompat="@drawable/ic_search" />
8680
</RelativeLayout>
@@ -139,13 +133,11 @@
139133
android:layout_height="wrap_content"
140134
android:layout_gravity="bottom"
141135
android:layout_marginStart="@dimen/layoutMargin1"
142-
android:layout_marginLeft="@dimen/layoutMargin1"
143136
android:background="@drawable/button_go"
144137
android:contentDescription="@string/cdImeDelete"
145138
android:padding="@dimen/layoutMargin1"
146139
android:paddingTop="@dimen/layoutMargin2"
147140
android:paddingEnd="@dimen/layoutMargin2"
148-
android:paddingRight="@dimen/layoutMargin2"
149141
android:paddingBottom="@dimen/layoutMargin2"
150142
app:srcCompat="@drawable/ic_backspace" />
151143
</RelativeLayout>

‎app/src/main/res/layout/activity_recognizer.xml

-4
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,9 @@
2424
android:layout_width="wrap_content"
2525
android:layout_height="wrap_content"
2626
android:layout_alignParentStart="true"
27-
android:layout_alignParentLeft="true"
2827
android:layout_alignParentTop="true"
2928
android:layout_margin="@dimen/layoutMargin4dp"
3029
android:layout_toStartOf="@+id/bSettings"
31-
android:layout_toLeftOf="@+id/bSettings"
3230
android:ellipsize="end"
3331
android:lines="3"
3432
android:textColor="?android:attr/textColorPrimary"
@@ -41,7 +39,6 @@
4139
android:layout_height="@dimen/layoutMargin32"
4240
android:layout_alignParentTop="true"
4341
android:layout_alignParentEnd="true"
44-
android:layout_alignParentRight="true"
4542
android:background="@drawable/button_go"
4643
android:contentDescription="@string/cdSettings"
4744
app:srcCompat="@drawable/ic_settings" />
@@ -53,7 +50,6 @@
5350
android:layout_height="@dimen/layoutMargin32"
5451
android:layout_below="@+id/bSettings"
5552
android:layout_alignParentEnd="true"
56-
android:layout_alignParentRight="true"
5753
android:background="@drawable/button_go"
5854
android:contentDescription="Enter Picture-in-picture mode"
5955
app:srcCompat="@drawable/ic_picture_in_picture"

‎app/src/main/res/layout/activity_rewrites_loader.xml

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
android:layout_width="match_parent"
2525
android:layout_height="wrap_content"
2626
android:layout_marginEnd="@dimen/layoutMargin4dp"
27-
android:layout_marginRight="@dimen/layoutMargin4dp"
2827
android:layout_weight="4"
2928
android:completionThreshold="1"
3029
android:hint="@string/hintName"

‎app/src/main/res/layout/button_combo_selector.xml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ set color to be the icon color
1010
android:layout_width="wrap_content"
1111
android:layout_height="wrap_content"
1212
android:layout_alignParentStart="true"
13-
android:layout_alignParentLeft="true"
1413
android:layout_alignParentBottom="true"
1514
android:layout_centerVertical="true"
1615
android:clipChildren="false"

‎app/src/main/res/layout/editor_bottom_bar.xml

-4
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,21 @@
99
android:layout_width="wrap_content"
1010
android:layout_height="wrap_content"
1111
android:layout_alignParentStart="true"
12-
android:layout_alignParentLeft="true"
1312
android:layout_centerVertical="true"
14-
android:layout_toLeftOf="@+id/bSmallMic"
1513
android:contentDescription="@string/cdChangeCombo" />
1614

1715
<ImageButton
1816
android:id="@+id/bSmallMic"
1917
android:layout_width="wrap_content"
2018
android:layout_height="wrap_content"
2119
android:layout_alignParentEnd="true"
22-
android:layout_alignParentRight="true"
2320
android:layout_centerVertical="true"
2421
android:background="@drawable/button_go"
2522
android:contentDescription="@string/cdMicrophone"
2623
android:minWidth="@dimen/layoutMargin3"
2724
android:minHeight="@dimen/layoutMargin3"
2825
android:padding="@dimen/layoutMargin1"
2926
android:paddingStart="@dimen/layoutMargin2"
30-
android:paddingLeft="@dimen/layoutMargin2"
3127
android:paddingTop="@dimen/layoutMargin2"
3228
app:srcCompat="@drawable/ic_baseline_mic_24" />
3329
</RelativeLayout>

‎app/src/main/res/layout/list_item_app.xml

-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
android:layout_height="wrap_content"
1212
android:layout_alignParentTop="true"
1313
android:layout_marginEnd="5dp"
14-
android:layout_marginRight="5dp"
1514
android:adjustViewBounds="true"
1615
android:contentDescription="@string/cdAppIcon"
1716
android:maxWidth="48dp"
@@ -24,7 +23,6 @@
2423
android:layout_width="wrap_content"
2524
android:layout_height="wrap_content"
2625
android:layout_toEndOf="@+id/itemAppIcon"
27-
android:layout_toRightOf="@+id/itemAppIcon"
2826
android:maxLines="1"
2927
android:text="@string/labelActivityHandsfreeDemo"
3028
android:textColor="?android:textColorPrimary"
@@ -36,7 +34,6 @@
3634
android:layout_height="wrap_content"
3735
android:layout_below="@+id/itemAppName"
3836
android:layout_toEndOf="@+id/itemAppIcon"
39-
android:layout_toRightOf="@+id/itemAppIcon"
4037
android:text="@string/dialogTitleChangeGrammarUrl"
4138
android:textSize="@dimen/textSize2" />
4239

@@ -56,7 +53,6 @@
5653
android:layout_height="wrap_content"
5754
android:layout_alignParentTop="true"
5855
android:layout_alignParentEnd="true"
59-
android:layout_alignParentRight="true"
6056
android:padding="2dp"
6157
android:text="@string/defaultRecordingRate"
6258
android:textSize="@dimen/textSize2" />

‎app/src/main/res/layout/list_item_combo.xml

-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
android:layout_width="wrap_content"
1010
android:layout_height="wrap_content"
1111
android:layout_alignParentStart="true"
12-
android:layout_alignParentLeft="true"
1312
android:paddingBottom="@dimen/layoutMargin4dp"
1413
android:textAppearance="?android:attr/textAppearanceMedium"
1514
android:textColor="?android:textColorPrimary" />
@@ -21,7 +20,6 @@
2120
android:layout_below="@+id/language"
2221
android:layout_alignBottom="@+id/service"
2322
android:layout_alignParentStart="true"
24-
android:layout_alignParentLeft="true"
2523
android:adjustViewBounds="true"
2624
android:contentDescription="@string/cdServiceIcon"
2725
android:maxWidth="24dp"
@@ -34,7 +32,6 @@
3432
android:layout_height="wrap_content"
3533
android:layout_below="@+id/language"
3634
android:layout_toEndOf="@+id/serviceIcon"
37-
android:layout_toRightOf="@+id/serviceIcon"
3835
android:paddingStart="@dimen/layoutMargin4dp"
3936
android:paddingLeft="@dimen/layoutMargin4dp"
4037
android:paddingEnd="@dimen/layoutMargin4dp"
@@ -47,7 +44,6 @@
4744
android:layout_width="wrap_content"
4845
android:layout_height="wrap_content"
4946
android:layout_alignParentEnd="true"
50-
android:layout_alignParentRight="true"
5147
android:layout_centerVertical="true" />
5248

5349
</RelativeLayout>

‎app/src/main/res/layout/list_item_grammar.xml

-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818
android:layout_width="wrap_content"
1919
android:layout_height="wrap_content"
2020
android:layout_marginStart="5dp"
21-
android:layout_marginLeft="5dp"
2221
android:layout_toEndOf="@+id/itemGrammarName"
23-
android:layout_toRightOf="@+id/itemGrammarName"
2422
android:padding="1dp"
2523
android:text="@string/labelRewritesChooser"
2624
android:textColor="@color/green1"

‎app/src/main/res/layout/list_item_recservice.xml

-3
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
android:layout_width="wrap_content"
1111
android:layout_height="wrap_content"
1212
android:layout_alignParentStart="true"
13-
android:layout_alignParentLeft="true"
1413
android:layout_alignParentTop="true"
1514
android:layout_marginEnd="@dimen/layoutMargin4dp"
16-
android:layout_marginRight="@dimen/layoutMargin4dp"
1715
android:layout_marginBottom="@dimen/layoutMargin4dp"
1816
android:adjustViewBounds="true"
1917
android:contentDescription="@string/cdServiceIcon"
@@ -28,7 +26,6 @@
2826
android:layout_height="wrap_content"
2927
android:layout_alignBottom="@id/serviceIcon"
3028
android:layout_toEndOf="@+id/serviceIcon"
31-
android:layout_toRightOf="@+id/serviceIcon"
3229
android:padding="@dimen/layoutMargin4dp"
3330
android:textAppearance="?android:attr/textAppearanceMedium"
3431
android:textColor="?android:textColorPrimary"

‎app/src/main/res/layout/list_item_rewrites.xml

-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
android:id="@+id/rewritesId"
1010
android:layout_width="wrap_content"
1111
android:layout_height="wrap_content"
12-
android:layout_alignParentLeft="true"
1312
android:layout_alignParentStart="true"
1413
android:layout_centerVertical="true"
1514
android:textAppearance="?android:attr/textAppearanceMedium"
@@ -20,7 +19,6 @@
2019
android:layout_width="wrap_content"
2120
android:layout_height="wrap_content"
2221
android:layout_alignParentEnd="true"
23-
android:layout_alignParentRight="true"
2422
android:layout_centerVertical="true" />
2523

2624
</RelativeLayout>

‎app/src/main/res/layout/list_item_server.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@
2727
android:id="@+id/itemServerStatus"
2828
android:layout_width="wrap_content"
2929
android:layout_height="wrap_content"
30-
android:layout_alignParentEnd="true"
31-
android:layout_alignParentRight="true"
3230
android:layout_alignParentTop="true"
31+
android:layout_alignParentEnd="true"
3332
android:text="@string/middot"
3433
android:textColor="@color/green1"
3534
android:textSize="@dimen/textSize3"

‎app/src/main/res/layout/recognition_service_ws_url.xml

-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
android:layout_width="wrap_content"
7070
android:layout_height="wrap_content"
7171
android:layout_marginEnd="@dimen/layoutMargin4dp"
72-
android:layout_marginRight="@dimen/layoutMargin4dp"
7372
android:digits="0123456789."
7473
android:hint="@string/hintLocalServer"
7574
android:imeOptions="actionDone"

‎app/src/main/res/layout/voice_ime_view.xml

-9
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,11 @@
2424
android:layout_width="wrap_content"
2525
android:layout_height="wrap_content"
2626
android:layout_alignParentStart="true"
27-
android:layout_alignParentLeft="true"
2827
android:layout_alignParentTop="true"
2928
android:background="@drawable/button_go"
3029
android:contentDescription="@string/cdChangeInputMethod"
3130
android:padding="@dimen/layoutMargin1"
3231
android:paddingEnd="@dimen/layoutMargin2"
33-
android:paddingRight="@dimen/layoutMargin2"
3432
android:paddingBottom="@dimen/layoutMargin2"
3533
app:srcCompat="@drawable/ic_ime" />
3634

@@ -59,9 +57,7 @@
5957
android:layout_centerVertical="true"
6058
android:layout_margin="@dimen/layoutMargin4dp"
6159
android:layout_toStartOf="@+id/bImeAction"
62-
android:layout_toLeftOf="@+id/bImeAction"
6360
android:layout_toEndOf="@+id/bImeKeyboard"
64-
android:layout_toRightOf="@+id/bImeKeyboard"
6561
android:ellipsize="start"
6662
android:gravity="center"
6763
android:singleLine="true"
@@ -75,12 +71,10 @@
7571
android:layout_height="wrap_content"
7672
android:layout_alignParentTop="true"
7773
android:layout_alignParentEnd="true"
78-
android:layout_alignParentRight="true"
7974
android:background="@drawable/button_go"
8075
android:contentDescription="@string/cdGo"
8176
android:padding="@dimen/layoutMargin1"
8277
android:paddingStart="@dimen/layoutMargin2"
83-
android:paddingLeft="@dimen/layoutMargin2"
8478
android:paddingBottom="@dimen/layoutMargin2"
8579
app:srcCompat="@drawable/ic_search" />
8680
</RelativeLayout>
@@ -127,9 +121,7 @@
127121
android:layout_centerHorizontal="true"
128122
android:layout_centerVertical="true"
129123
android:layout_marginStart="@dimen/layoutMargin1"
130-
android:layout_marginLeft="@dimen/layoutMargin1"
131124
android:layout_toEndOf="@+id/bImeStartStop"
132-
android:layout_toRightOf="@+id/bImeStartStop"
133125
android:gravity="center"
134126
android:orientation="vertical"
135127
android:visibility="gone">
@@ -145,7 +137,6 @@
145137
android:padding="@dimen/layoutMargin1"
146138
android:paddingTop="@dimen/layoutMargin3"
147139
android:paddingEnd="@dimen/layoutMargin3"
148-
android:paddingRight="@dimen/layoutMargin3"
149140
android:paddingBottom="@dimen/layoutMargin3"
150141
app:srcCompat="@drawable/ic_backspace" />
151142
</LinearLayout>

0 commit comments

Comments
 (0)
Failed to load comments.