Do not defensively check if the recognizer component is present,

and fall back to the default recognizer if it is not.
Instead, always just call SpeechRecognizer.createSpeechRecognizer and
let it handle the error.

Author: Kaljurand

app/build.gradle

@@ -6,7 +6,7 @@ dependencies {
     // TODO: used only in ChunkedWebRecSessionResult, use Android's JSON library instead
     implementation 'com.googlecode.json-simple:json-simple:1.1'
     implementation 'com.koushikdutta.async:androidasync:3.1.0'
-    implementation 'org.jetbrains.kotlin:kotlin-stdlib:1.9.0'
+    implementation 'org.jetbrains.kotlin:kotlin-stdlib:1.9.20'
     implementation 'androidx.appcompat:appcompat:1.6.1'
     implementation 'androidx.preference:preference-ktx:1.2.1'
     implementation 'androidx.recyclerview:recyclerview:1.3.2'

app/src/main/java/ee/ioc/phon/android/speak/ServiceLanguageChooser.java

@@ -20,7 +20,6 @@
 import ee.ioc.phon.android.speak.utils.Utils;
 import ee.ioc.phon.android.speechutils.Extras;
 import ee.ioc.phon.android.speechutils.RecognitionServiceManager;
-import ee.ioc.phon.android.speechutils.utils.IntentUtils;
 import ee.ioc.phon.android.speechutils.utils.PreferenceUtils;
 
 
@@ -87,14 +86,11 @@ public ServiceLanguageChooser(Context context, SharedPreferences prefs, int keys
     }
 
     /**
-     * If the stored recognizer component name does not refer to an existing service on the device then we use
-     * the default service. This can happen if services get removed or renamed.
-     * TODO: improve
+     * Note that if the stored recognizer component name does not refer to an existing service on the device,
+     * because it has been removed in the mean time, then SpeechRecognizer returns error 10
+     * ("Bind to system recognition service failed with error 10").
      */
     public SpeechRecognizer getSpeechRecognizer() {
-        if (mRecognizerComponentName == null || !IntentUtils.isRecognitionAvailable(mContext, mRecognizerComponentName)) {
-            return SpeechRecognizer.createSpeechRecognizer(mContext);
-        }
         return SpeechRecognizer.createSpeechRecognizer(mContext, mRecognizerComponentName);
     }
 

app/src/main/java/ee/ioc/phon/android/speak/view/SpeechInputView.java

@@ -908,6 +908,23 @@ public void onEndOfSpeech() {
          * are generated by our implementation, others can be generated by the
          * framework, e.g. ERROR_CLIENT results from
          * "stopListening called with no preceding startListening".
+         * <p>
+         * Note: we currently cover error codes up to API level 8 + code 10 (from API level 31).
+         * Code 10 ("too many requests"?) results from trying to use a non-existing recognizer
+         * component.
+         *
+         * <ul>
+         * <li>1 NETWORK_TIMEOUT
+         * <li>2 NETWORK
+         * <li>3 AUDIO
+         * <li>4 SERVER
+         * <li>5 CLIENT
+         * <li>6 SPEECH TIMEOUT
+         * <li>7 NO MATCH
+         * <li>8 RECOGNIZER BUSY
+         * <li>9 INSUFFICIENT PERMISSIONS
+         * <li>10 TOO MANY REQUESTS
+         * </ul>
          *
          * @param errorCode SpeechRecognizer error code
          */
@@ -944,8 +961,11 @@ public void onError(final int errorCode) {
                 case SpeechRecognizer.ERROR_SPEECH_TIMEOUT:
                     setGuiInitState(R.string.errorImeResultSpeechTimeout);
                     break;
+                case SpeechRecognizer.ERROR_TOO_MANY_REQUESTS:
+                    setGuiInitState(R.string.errorImeResultTooManyRequests);
+                    break;
                 default:
-                    Log.e("This might happen in future Android versions: code " + errorCode);
+                    Log.e("Error code > 10 shown as code 5: code " + errorCode);
                     setGuiInitState(R.string.errorImeResultClientError);
                     break;
             }

app/src/main/res/values-et/strings.xml

@@ -214,7 +214,7 @@
     <string name="errorFailedGetGrammarUrl">VIGA: grammatika aadressi valimine luhtus</string>
     <string name="errorFailedGetServerUrl">VIGA: serveri aadressi valimine luhtus</string>
 
-    // SpeechRecognizer error messages (9) shown in the IME
+    // SpeechRecognizer error messages shown in the IME
     <string name="errorImeResultAudioError">lindistamine luhtus</string>
     <string name="errorImeResultNetworkError">serveriga puudub ühendus</string>
     <string name="errorImeResultNetworkTimeoutError">server ei tööta</string>
@@ -224,6 +224,7 @@
     <string name="errorImeResultSpeechTimeout">kõnet polnud kuulda</string>
     <string name="errorImeResultNoMatch">transkribeerimine luhtus</string>
     <string name="errorImeResultInsufficientPermissions">vajalikud õigused puuduvad</string>
+    <string name="errorImeResultTooManyRequests">liiga palju päringuid</string>
 
     <string name="errorResultAudioError">Lindistamine luhtus.
         Võibolla mõni teine rakendus parasjagu lindistab.</string>

app/src/main/res/values/strings.xml

@@ -218,7 +218,7 @@
     <string name="errorFailedLaunchApp">ERROR: App cannot be launched or is not installed (anymore): %1$s</string>
     <string name="errorFailedPlayAudio">ERROR: Failed to play the recorded audio: %1$s, %2$s</string>
 
-    // SpeechRecognizer error messages (9) shown in the IME
+    // SpeechRecognizer error messages shown in the IME
     <string name="errorImeResultAudioError">audio recording failed</string>
     <string name="errorImeResultNetworkError">server not reachable</string>
     <string name="errorImeResultNetworkTimeoutError">network connection timeout</string>
@@ -228,6 +228,7 @@
     <string name="errorImeResultInsufficientPermissions">insufficient permissions</string>
     <string name="errorImeResultClientError">general app error</string>
     <string name="errorImeResultServerError">recognizer server error</string>
+    <string name="errorImeResultTooManyRequests">too many requests</string>
 
     <string name="errorResultAudioError">Audio recording failed. Maybe another app is currently recording.</string>
     <string name="errorResultNetworkError">Server not reachable. The internet connection is broken or the server is down.</string>

build.gradle

@@ -5,7 +5,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:8.3.0'
-        classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0'
+        classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.20'
     }
 }