Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old service #40

Merged
merged 29 commits into from
Sep 21, 2015
Merged

Remove old service #40

merged 29 commits into from
Sep 21, 2015

Conversation

Kaljurand
Copy link
Owner

Refactoring in order to deprecate RecognizerIntentActivity and RecognizerIntentService.

A new voice search panel was created that reuses the existing speech keyboard UI to offer the same features and look-and-feel on both the speech keyboard and the voice search panel. Some features offered by the old panel were dropped: support for screen rotation during recognition, some UI feedback: byte/time/chunk counter, waveform display.

Other changes:

  • reorganization of the settings menu (e.g. audio cues are now part of the service configuration)
  • speech keyboard: long press selects all text
  • search panel: number of returned recognition hypothesis is now configurable
  • bugfixes

refactor the existing RecognizerIntent to share code with the new one.
This simplifies deleting the complete text: long press + swipe left
(previously: n * swipe left)
app/src/ee/ioc/phon/android/speak/VoiceImeService.java -> app/src/ee/ioc/phon/android/speak/service/SpeechInputMethodService.java
app/src/ee/ioc/phon/android/speak/VoiceImeView.java -> app/src/ee/ioc/phon/android/speak/view/SpeechInputView.java
app/src/ee/ioc/phon/android/speak/MicButton.java -> app/src/ee/ioc/phon/android/speak/view/MicButton.java
(instead of hiding as before)

+ some refactoring
- ee.ioc.phon.android.extra.RESULT_PREFIX
- ee.ioc.phon.android.extra.RESULT_SUFFIX

The idea is to wrap the input into e.g.:

- play INPUT on YouTube
- log((INPUT)^-1)
- ...
which for some reason is missing in SpeechRecognizer
Kaljurand added a commit that referenced this pull request Sep 21, 2015
@Kaljurand Kaljurand merged commit 67b3e5f into master Sep 21, 2015
@Kaljurand Kaljurand deleted the remove_old_service branch February 23, 2016 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant