Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for --python_bin command line option. #317

Open
vb64 opened this issue Mar 21, 2025 · 3 comments
Open

Request for --python_bin command line option. #317

vb64 opened this issue Mar 21, 2025 · 3 comments

Comments

@vb64
Copy link

vb64 commented Mar 21, 2025

First of all, thank you very much for this project, it is really useful for a lot of people.

I use several versions of python for my task and this line of code calls the wrong version of python.

f'python -m demucs.separate -n htdemucs --two-stems=vocals "{args.audio}" -o temp_outputs --device "{args.device}"'

If change this line like this

f'{args.python_bin} -m demucs.separate -n htdemucs --two-stems=vocals "{args.audio}" -o temp_outputs --device "{args.device}"'

and add support for the corresponding command line option (with default value 'python' for backward compatibility), it would save me from having to patch the diarize.py code.

If you pre-approve this change, I can prepare a pull request with the necessary changes.

@vb64
Copy link
Author

vb64 commented Mar 21, 2025

I see that this change needs to be applied in several places:

f35796c

@MahmoudAshraf97
Copy link
Owner

Hi, do you use different versions through venv?

@vb64
Copy link
Author

vb64 commented Mar 21, 2025

One version is from venv, the other two are present in the toolchain outside of venv and call directly.

I know it's bad, but it happened that way for "historical reasons".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants