Skip to content

Commit fe219ad

Browse files
committedAug 25, 2016
Fix bug with server port settings
1 parent 64be8d8 commit fe219ad

File tree

3 files changed

+17
-8
lines changed

3 files changed

+17
-8
lines changed
 

‎app/build.gradle

+8-6
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,18 @@ apply plugin: 'com.android.application'
22

33

44
android {
5-
signingConfigs {
6-
7-
}
85
compileSdkVersion 24
96
buildToolsVersion "24.0.1"
107
defaultConfig {
118
applicationId "info.dvkr.screenstream"
129
minSdkVersion 21
1310
targetSdkVersion 24
14-
versionCode 7
15-
versionName "1.1.0"
11+
versionCode 8
12+
versionName "1.1.1"
1613

1714
resConfigs "en", "ru"
1815
}
16+
1917
buildTypes {
2018
release {
2119
minifyEnabled true
@@ -28,6 +26,11 @@ android {
2826
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
2927
}
3028
}
29+
30+
dataBinding {
31+
enabled = true
32+
}
33+
3134
aaptOptions {
3235
cruncherEnabled = false
3336
}
@@ -37,7 +40,6 @@ dependencies {
3740
compile fileTree(include: ['*.jar'], dir: 'libs')
3841
compile 'com.android.support:design:24.2.0'
3942
compile 'com.google.firebase:firebase-crash:9.4.0'
40-
// compile "com.androidplot:androidplot-core:0.9.8"
4143
}
4244

4345
apply plugin: 'com.google.gms.google-services'

‎app/src/main/java/info/dvkr/screenstream/ForegroundService.java

+2
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,7 @@ private Notification getNotificationStart() {
240240
final PendingIntent pendingMainActivityIntent = PendingIntent.getActivity(this, 0, mainActivityIntent, 0);
241241

242242
final NotificationCompat.Builder startNotificationBuilder = new NotificationCompat.Builder(this);
243+
startNotificationBuilder.setVisibility(NotificationCompat.VISIBILITY_PUBLIC);
243244
startNotificationBuilder.setSmallIcon(R.drawable.ic_cast_http_24dp);
244245
startNotificationBuilder.setColor(ContextCompat.getColor(this, R.color.colorPrimaryDark));
245246
startNotificationBuilder.setContentTitle(getResources().getString(R.string.ready_to_stream));
@@ -256,6 +257,7 @@ private Notification getNotificationStop() {
256257
final PendingIntent pendingMainActivityIntent = PendingIntent.getActivity(this, 0, mainActivityIntent, 0);
257258

258259
final NotificationCompat.Builder stopNotificationBuilder = new NotificationCompat.Builder(this);
260+
stopNotificationBuilder.setVisibility(NotificationCompat.VISIBILITY_PUBLIC);
259261
stopNotificationBuilder.setSmallIcon(R.drawable.ic_cast_http_24dp);
260262
stopNotificationBuilder.setColor(ContextCompat.getColor(this, R.color.colorPrimaryDark));
261263
stopNotificationBuilder.setContentTitle(getResources().getString(R.string.stream));

‎app/src/main/java/info/dvkr/screenstream/SettingsActivity.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public boolean onPreferenceChange(Preference preference, Object data) {
5454
pinNumberTextPreference.setOnPreferenceChangeListener(new Preference.OnPreferenceChangeListener() {
5555
@Override
5656
public boolean onPreferenceChange(Preference preference, Object data) {
57-
final int pinStringLength = ((String) data).length();
57+
final int pinStringLength = data.toString().length();
5858
if (pinStringLength != PIN_DIGITS_COUNT) {
5959
Toast.makeText(getActivity().getApplicationContext(), getResources().getString(R.string.pin_digits_count), Toast.LENGTH_LONG).show();
6060
return false;
@@ -72,7 +72,12 @@ public boolean onPreferenceChange(Preference preference, Object data) {
7272
portNumberTextPreference.setOnPreferenceChangeListener(new Preference.OnPreferenceChangeListener() {
7373
@Override
7474
public boolean onPreferenceChange(Preference preference, Object data) {
75-
final int portNumber = Integer.parseInt((String) data);
75+
final String portString = data.toString();
76+
if (portString == null || portString.length() == 0 || portString.length() > 5 || portString.length() < 4) {
77+
Toast.makeText(getActivity().getApplicationContext(), portRange, Toast.LENGTH_LONG).show();
78+
return false;
79+
}
80+
final int portNumber = Integer.parseInt(portString);
7681
if ((portNumber < MIN_PORT_NUMBER) || (portNumber > MAX_PORT_NUMBER)) {
7782
Toast.makeText(getActivity().getApplicationContext(), portRange, Toast.LENGTH_LONG).show();
7883
return false;

0 commit comments

Comments
 (0)
Failed to load comments.