Add support for AppCompat theme

Author: gkalab

.idea/codeStyles/Project.xml

@@ -0,0 +1,14 @@
+## For more details on how to configure your build environment visit
+# http://www.gradle.org/docs/current/userguide/build_environment.html
+#
+# Specifies the JVM arguments used for the daemon process.
+# The setting is particularly useful for tweaking memory settings.
+# Default value: -Xmx1024m -XX:MaxPermSize=256m
+# org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
+#
+# When configured, Gradle will run in incubating parallel mode.
+# This option should only be used with decoupled projects. More details, visit
+# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
+# org.gradle.parallel=true
+#Thu Aug 22 19:41:12 CEST 2019
+org.gradle.jvmargs=-Xmx2048M -Dkotlin.daemon.jvm.options\="-Xmx1024M"

.idea/saveactions_settings.xml

@@ -25,7 +25,7 @@
         android:icon="@drawable/icon"
         android:label="@string/app_name"
         android:name=".ScidApplication"
-        android:theme="@style/Theme.AppCompat.Light">
+        android:theme="@style/AppTheme">
         <activity
             android:configChanges="orientation"
             android:label="@string/app_name"

gradle.properties

@@ -1,8 +1,10 @@
 package org.scid.android;
 
+import android.content.Context;
 import android.content.SharedPreferences;
 import android.content.SharedPreferences.Editor;
 import android.graphics.Color;
+import android.support.v4.content.ContextCompat;
 
 class ColorTheme {
 	private static ColorTheme inst = null;
@@ -51,7 +53,7 @@ static ColorTheme instance() {
 					"#FFFFFFFF", "#FFAFC4D4", "#A01F1FFF", "#A0FF1F1F",
 					"#501F1FFF", "#50FF1F1F", "#1E1F1FFF", "#28FF1F1F"}};
 
-	final void readColors(SharedPreferences preferences) {
+	final void readColors(Context context, SharedPreferences preferences) {
 		for (int i = 0; i < numColors; i++) {
 			String prefName = prefPrefix + prefNames[i];
 			String defaultColor = themeColors[0][i];
@@ -61,16 +63,17 @@ final void readColors(SharedPreferences preferences) {
 			} catch (IllegalArgumentException e) {
 				colorTable[i] = 0;
 			}
+			colorTable[CURRENT_MOVE] = ContextCompat.getColor(context, R.color.accent);
 		}
 	}
 
-	final void setTheme(SharedPreferences preferences, int themeType) {
+	final void setTheme(Context context, SharedPreferences preferences, int themeType) {
 		Editor editor = preferences.edit();
 		for (int i = 0; i < numColors; i++)
 			editor.putString(prefPrefix + prefNames[i],
 					themeColors[themeType][i]);
 		editor.commit();
-		readColors(preferences);
+		readColors(context, preferences);
 	}
 
 	final int getColor(int colorType) {

scidOnTheGo/src/main/AndroidManifest.xml

@@ -170,7 +170,7 @@ public void onRequestPermissionsResult(int requestCode, String[] permissions, in
 					&& grantResults[0] == PackageManager.PERMISSION_GRANTED) {
 				initAfterPermissionSuccess();
 			} else {
-				final AlertDialog d = new AlertDialog.Builder(this)
+				AlertDialog d = new AlertDialog.Builder(this)
 						.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() {
 							@Override
 							public void onClick(DialogInterface dialog, int which) {
@@ -900,7 +900,7 @@ private void readPrefs() {
 		pgnOptions.exp.playerAction = false;
 		pgnOptions.exp.clockInfo = false;
 
-		ColorTheme.instance().readColors(preferences);
+		ColorTheme.instance().readColors(this, preferences);
 		cb.setColors();
 
 		String engineName = preferences.getString(ANALYSIS_ENGINE, engineManager
@@ -1281,7 +1281,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
 		case RESULT_PREFERENCES:
 			readPrefs();
 			String theme = preferences.getString("colorTheme", "0");
-			ColorTheme.instance().setTheme(preferences, Integer.parseInt(theme));
+			ColorTheme.instance().setTheme(this, preferences, Integer.parseInt(theme));
 			cb.setColors();
 			setGameMode();
 			break;
@@ -1429,7 +1429,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
 							ANALYSIS_ENGINE, null);
 					if (analysisEngine != null
 							&& analysisEngine.equals(_engineName)) {
-						final EngineManager.EngineChangeListener _listener = new EngineManager.EngineChangeListener() {
+						EngineManager.EngineChangeListener _listener = new EngineManager.EngineChangeListener() {
 
 							@Override
 							public void engineChanged(EngineChangeEvent event) {
@@ -1534,7 +1534,7 @@ private void loadScidFile(String fileName) {
 	private void addNewEngine(final String engineName, String executable,
 			final String enginePackage, final int engineVersion, boolean makeCurrentEngine, boolean copied) {
 		if (makeCurrentEngine) {
-			final EngineManager.EngineChangeListener _listener = new EngineManager.EngineChangeListener() {
+			EngineManager.EngineChangeListener _listener = new EngineManager.EngineChangeListener() {
 
 				@Override
 				public void engineChanged(EngineChangeEvent event) {
@@ -1578,7 +1578,7 @@ public void setFromSelection(int sq) {
 	}
 
 	@Override
-	public void setStatusString(final String str) {
+	public void setStatusString(String str) {
 		String prefix = "";
 		if (getScidAppContext().isDeleted()) {
 			prefix = "<font color='red'><b>DELETED</b></font> ";
@@ -1766,7 +1766,7 @@ private void showAboutDialog() {
 	}
 
 	private AlertDialog createCreateDatabaseDialog() {
-		final AlertDialog.Builder builder = new AlertDialog.Builder(this);
+		AlertDialog.Builder builder = new AlertDialog.Builder(this);
 		final EditText input = new EditText(this);
 		builder.setTitle(getText(R.string.create_db_title));
 		builder.setMessage(getText(R.string.create_db_message));
@@ -1804,8 +1804,8 @@ private AlertDialog createSearchDialog() {
 		final int SEARCH_CURRENT_BOARD = 1;
 		final int SEARCH_HEADER = 2;
 		final int SHOW_FAVORITES = 3;
-		List<CharSequence> lst = new ArrayList<CharSequence>();
-		List<Integer> actions = new ArrayList<Integer>();
+		List<CharSequence> lst = new ArrayList<>();
+		List<Integer> actions = new ArrayList<>();
 		lst.add(getString(R.string.reset_filter));
 		actions.add(RESET_FILTER);
 		lst.add(getString(R.string.search_current_board));
@@ -2088,7 +2088,7 @@ private void saveCurrentGameId() {
 	}
 
 	private void resetFilter() {
-		final String fileName = getScidAppContext().getCurrentFileName();
+		String fileName = getScidAppContext().getCurrentFileName();
 		if (fileName.length() != 0) {
 			DataBaseView dbv = setDataBaseViewFromFile();
 			if (dbv != null) {
@@ -2144,7 +2144,7 @@ private DataBaseView setDataBaseViewFromFile() {
 	 *	   if set to false only reset the dbv if the file name changes or the current dbv is null
 	 */
 	private DataBaseView setDataBaseViewFromFile(boolean alwaysResetDbView) {
-		final String currentScidFile = preferences.getString("currentScidFile", "");
+		String currentScidFile = preferences.getString("currentScidFile", "");
 		if (currentScidFile.length() == 0) {
 			return null;
 		}

scidOnTheGo/src/main/java/org/scid/android/ColorTheme.java

@@ -18,7 +18,8 @@
             android:includeFontPadding="true"
             android:typeface="monospace"
             android:textStyle="bold"
-            android:textSize="18dip" />
+            android:textSize="18dip"
+            android:textColor="?attr/colorAccent"/>
         <ScrollView
             android:id="@+id/moveListScrollView"
             android:layout_width="fill_parent"
@@ -31,7 +32,8 @@
                 android:layout_height="wrap_content"
                 android:includeFontPadding="true"
                 android:typeface="monospace"
-                android:textSize="10dip" />
+                android:textSize="10dip"
+                android:textColor="?android:attr/textColorPrimary"/>
         </ScrollView>
     </LinearLayout>
     <view