Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All : Fix for "Changing the type of one list changes it for all the lists" issue #11986

Conversation

Paramesh-T-S
Copy link
Contributor

@Paramesh-T-S Paramesh-T-S commented Mar 18, 2025

Summary :

  • All: Resolves Changing the type of one list changes it for all the lists #11971 - Removed growSelectionToNodeUsage in markdownCommands and updated required tests.
  • This pull request contains fix for the above issue, now only the focused or selected text will change (This fix affects all ListTypes).
  • Kindly refer attached GIF below.

Fix-Recording-11971

Added automated tests and Manual Test Process given below for reference :

  1. Have a note with this content:
- One list
  - one
  - two
  - three

- | <-- caret here
  1. Click the list options (All 3 will be affected in this change) button to convert the new list to a checkbox list.
  2. The editor will select the current list and apply the changes only to the list.

@Paramesh-T-S
Copy link
Contributor Author

Hi , Any update on this PR?

@laurent22
Copy link
Owner

That looks good, thank you for fixing this!

@laurent22 laurent22 merged commit cfd98d2 into laurent22:dev Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the type of one list changes it for all the lists
2 participants