-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateResult.request_id field for tracking model usage. #6058
base: main
Are you sure you want to change the base?
Conversation
agree |
Thanks for the PR, though I would like to hold on a bit before the questions are resolved: #6049 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor (semantic) technicality, but at least in both Open AI client and Anthropic, the id is generated by the LLM API and is not created at the time of the request. It is a response ID (which can be used to track what an LLM said in response to a request. One could theoretically track a request ID separately if needed.
Thanks for adding the Overall, the approach of adding the optional field to However, there are two issues I found during review:
|
Why are these changes needed?
Related issue number
Closes #6049
Checks