Install Lua 5.4 on Container Images #1133
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098
I did debug the source code and found we have following error when we run the server on a container, which I interpret it as lua54 not being installed on the container.
The error is not visible since we ignore the error in sessionScriptCache.TryLoad method.
garnet/libs/server/Lua/LuaCommands.cs
Line 116 in 3efcc05
Error on container
I'll change the other images when we agree this is the right fix.