misc/language: parse forced tag from external subtitle tracks #16061
+96
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
reviewed
Mar 16, 2025
kasper93
reviewed
Mar 16, 2025
tgt
force-pushed
the
forced-external-subs
branch
from
6dcf014 to
853476f
Compare
|
Download the artifacts for this pull request: |
1 task
kasper93
reviewed
Mar 26, 2025
tgt
force-pushed
the
forced-external-subs
branch
from
853476f to
2389df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a
forcedargument to thesub-addcommand.Fixes: #16060.
This is very similar to #16020.
It does not add support for
<title>.forced.<lang>.<ext>as suggested in my issue and just adds support for<title>.<lang>.forced.<ext>as this is in line with the change in the sdh pull request.I don't think it makes sense for a subtitle track to be marked as both sdh and forced, so I didn't update the filename parser to support both tags at once.