Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32: remove SC_RESTORE handling #16127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kasper93
Copy link
Contributor

No description provided.

We don't support other ways of fullscreening.

Fixes: mpv-player#16119
It doesn't seem to be neeeded anymore.
@kasper93
Copy link
Contributor Author

@na-na-hi do you know where this would be needed? I couldn't reproduce on my end. Maybe it was FSE mode that is no longer with us.

Copy link

Download the artifacts for this pull request:

Windows
macOS

@na-na-hi
Copy link
Contributor

do you know where this would be needed?

After a maximized window is put in fullscreen, when you press win+down, it exits fullscreen in a maximized state.

@kasper93
Copy link
Contributor Author

do you know where this would be needed?

After a maximized window is put in fullscreen, when you press win+down, it exits fullscreen in a maximized state.

I see, but what is expected behavior in this case? Shouldn't it exit fullscreen? Same as win+down goes from maximized to windowed first.

@na-na-hi
Copy link
Contributor

I see, but what is expected behavior in this case? Shouldn't it exit fullscreen?

It does. As I already said, currently win+down in fullscreen exits fullscreen if window-maximized=yes. With this PR, it instead restores to the unmaximized size while still retaining the fullscreen state, so the window has no titlebar and cannot be resized or dragged.

@kasper93
Copy link
Contributor Author

kasper93 commented Mar 27, 2025

I see, but what is expected behavior in this case? Shouldn't it exit fullscreen?

It does. As I already said, currently win+down in fullscreen exits fullscreen if window-maximized=yes.

But if it is not maximized it minimize instead. Is this expected to you?

I found dozen other bugs when testing this again, so we can postpone this discussion. I only wanted to know if this is expected that fs=yes window-maximized=no minimizes the window instead of restoring it to window state.

@na-na-hi
Copy link
Contributor

But if it is not maximized it minimize instead. Is this expected to you?

win+down on a non-maximized window normally minimizes it. Technically fs=yes window-maximized=no is non-maximized. MPC-HC does the same thing, just in a more buggy way. VLC does nothing with win+down on fullscreen.

I don't think there is any expected behavior in this case. As long as it does not leave the window in a buggy state it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants