Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom completer for completing cargo build --packge <TAB> #15338

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nooma-42
Copy link
Contributor

@nooma-42 nooma-42 commented Mar 21, 2025

What does this PR try to resolve?

Fixes #15004

How should we test and review this PR?

Additional information

This supersedes #14553

@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@epage
Copy link
Contributor

epage commented Mar 24, 2025

In #14553 (comment), I expressed concern over keying off of the name of the command for deciding what kind of completions should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli suggestions for --package
5 participants