Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color-scheme support for rustup.rs #4209

Open
Nemo157 opened this issue Mar 3, 2025 · 2 comments
Open

color-scheme support for rustup.rs #4209

Nemo157 opened this issue Mar 3, 2025 · 2 comments

Comments

@Nemo157
Copy link
Member

Nemo157 commented Mar 3, 2025

Problem you are trying to solve

Visiting rustup.rs from a dark-theme device can be blinding as it is an almost entirely plain white page.

Solution you'd like

A simple @media (prefers-color-scheme: dark) based dark-mode style. The main rust-lang.org site seems to lack one as well (but is tempered a bit by the big blocks of background color reducing the overall brightness), but https://blog.rust-lang.org/ has a theme that I assume is consistent with the rest of the project.

Notes

No response

@djc
Copy link
Contributor

djc commented Mar 3, 2025

Sounds good to me -- happy to review a PR for this!

@apiraino
Copy link

apiraino commented Mar 5, 2025

@Nemo157 thank for mentioning my work on the blog (with the help of other, I'm proud to have contributed a dark theme there 😃 ). Please free to steal anything you may find useful there!

Dark colors on the blog were choosen based on what a browser extension (Dark Reader) suggested me at the time. To my knowledge we don't have a standard color palette for our websites, so you can take the blog as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants