Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonFree lib in F-Droid build #16

Closed
linsui opened this issue Jul 24, 2022 · 3 comments
Closed

NonFree lib in F-Droid build #16

linsui opened this issue Jul 24, 2022 · 3 comments

Comments

@linsui
Copy link

linsui commented Jul 24, 2022

https://gitlab.com/fdroid/fdroidserver/-/merge_requests/1011 androidx.core:core-google-shortcuts depends on firebase. Could you please take a look? Thanks!
zorgluf added a commit that referenced this issue Jul 25, 2022
@zorgluf
remove unused dependency (core-google-shortcut)
6a946cf 
#16
@zorgluf
Copy link
Owner

zorgluf commented Jul 25, 2022

Thanks for the report. This dep was introduced in shared shortcut functionalities but seams not necessary. A mistake from my side, sorry. It will be removed on next release expected in August. Is it too late? If yes, I will issue a quick fix release.

@linsui
Copy link
Author

linsui commented Jul 25, 2022

I have disabled affected versions. No need to be hurry. If it's a easy fix, e.g just removing the dep, I can do that on our side.

zorgluf added a commit that referenced this issue Jul 25, 2022
@zorgluf
remove unused dependency (core-google-shortcut)
829e07d 
#16
@zorgluf
Copy link
Owner

zorgluf commented Jul 25, 2022

No need, I had a few time to push the commits in release 2.6.1. Done.

@zorgluf zorgluf closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zorgluf @linsui