Fix write access error #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorgluf
reviewed
Apr 19, 2021
| @@ -431,7 +431,7 @@ public String getDefaultStyle() { | |||
|
|
|||
| public PageViewModel getNextPage(PageViewModel pageVM) { | |||
| int pos = getPosition(pageVM); | |||
| if (pos < getPages().getValue().size()-1) { | |||
| if (getPages().getValue() == null || pos < getPages().getValue().size()-1) { | |||
There was a problem hiding this comment.
Since it's not related to the issue, could you exclude this change to the commit ? Anyway, did you experience crash in this part of code ? Value shouldn't be null at this point.
|
sure, here is the new commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to enable writing to storage for recent Android version