Enabled and Enhanced Artifactory Detector #4207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
force-pushed
the
update/csm-1160
branch
from
badce59 to
3fd026a
Compare
shahzadhaider1
approved these changes
Jun 5, 2025
nabeelalam
reviewed
Jun 5, 2025
nabeelalam
reviewed
Jun 5, 2025
nabeelalam
reviewed
Jun 5, 2025
kashifkhan0771
force-pushed
the
update/csm-1160
branch
from
2062eac to
0dcc0e3
Compare
nabeelalam
approved these changes
Jun 24, 2025
bugbaba
reviewed
Jul 16, 2025
| @@ -26,14 +29,20 @@ var ( | |||
| defaultClient = detectors.DetectorHttpClientWithNoLocalAddresses | |||
|
|
|||
| // Make sure that your group is surrounded in boundary characters such as below to reduce false positives. | |||
| keyPat = regexp.MustCompile(`\b([a-zA-Z0-9]{73}|\b[a-zA-Z0-9]{64})`) | |||
| URLPat = regexp.MustCompile(`\b([A-Za-z0-9](?:[A-Za-z0-9\-]{0,61}[A-Za-z0-9])\.jfrog\.io)`) | |||
| keyPat = regexp.MustCompile(`\b([a-zA-Z0-9]{64,73})\b`) | |||
There was a problem hiding this comment.
Hi @kashifkhan0771,
Do correct me on this, old regex would have either matched 73 or 64 chars and the new one matches every thing in between.
have you confirmed that they keys size is now random and lies within this range? if not will it not lead to false positives?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables Artifactory detector and enhances it
oss-236
Checklist:
make test-community)?make lintthis requires golangci-lint)?