refactor: migrate hybridconnectivity to new folder structure #35522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved TypeSpec files from HybridConnectivity.Management/ to resource-manager/Microsoft.HybridConnectivity/HybridConnectivity/
- Unified TypeSpec and swagger files into single service folder following Azure guidelines
- Updated common-types references in swagger files for new folder depth
- Fixed readme.md input-file paths to use relative paths within service folder
- Updated tspconfig.yaml with correct emitter-output-dir and arm-types-dir
- Added suppressions.yaml for brownfield services not yet migrated to TypeSpec
- Preserved all existing tspconfig.yaml options for multiple language SDKs
- Successfully validated TypeSpec compilation
Follows new folder structure guideline:
specification/{orgName}/resource-manager/{rpNamespace}/{serviceName}/
All files now under: specification/hybridconnectivity/resource-manager/Microsoft.HybridConnectivity/HybridConnectivity/
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
- Fix arm-types-dir path to match new folder structure depth - Update output-file to use dynamic version-status pattern - Add azure-resource-provider-folder for resource-manager services - Regenerate swagger with corrected TypeSpec configuration - Ensure TypeSpec validation passes with proper common-types references
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows new folder structure guideline:
specification/{orgName}/resource-manager/{rpNamespace}/{serviceName}/
All files now under: specification/hybridconnectivity/resource-manager/Microsoft.HybridConnectivity/HybridConnectivity/
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.