Remove dev step from tooling builds (reducing memory pressure) and copy the minified file to a max.js file for backwards compat #16760
Conversation
…le for back compat
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16760/merge/testResults/ |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16760/merge/testResults/ |
path.join missing in the 'from' var
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16760/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16760/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16760/merge#BCU1XR#0 |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16760/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16760/merge/ |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
@RaananW if this looks good to you feel free to publish/merge! |
|
I assumed initial that https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16760/merge/babylon.max.js will be minified, but it isn't. should it be?... |
There was a problem hiding this comment.
resolve this comment after adding the changes to the core UMD packages :-)
@RaananW this PR doesn't impact babylon.max.js -- its only doing the change for the tools at first figured it was safer than enabling for all ? and see if we get any complaints? |
If that's enough to mitigate the memory issue, I'm good with it 🙂 |
Originally our build commands for our tools were running both dev and prod, outputted an unminified max.js file during CI. This impacted memory usage during build and is not necessary for debugging since we offer source maps.
This PR removes the dev step from our builds, so we won't be outputting the unminified max.js files anymore. But in order to preserve backwards compatibility for users who may have been referencing the .max.js file directly, we now copy the minified file to a .max.js file after the build is complete. This plugin will only run if the
minToMaxoption is set to true in the webpack configuration.