-
Notifications
You must be signed in to change notification settings - Fork 308
Write http.route tag as soon as possible in vert.x #8952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
approved these changes
Jun 10, 2025
f6fc3e6
to
954bb1f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027094
Total [baseline] (8.552 s) : 0, 8552349
Agent [candidate] (1.034 s) : 0, 1034460
Total [candidate] (8.577 s) : 0, 8577468
section iast
Agent [baseline] (1.16 s) : 0, 1160024
Total [baseline] (9.213 s) : 0, 9213273
Agent [candidate] (1.163 s) : 0, 1162850
Total [candidate] (9.251 s) : 0, 9250624
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.398 ms) : 0, 688398
BytebuddyAgent [candidate] (692.556 ms) : 0, 692556
GlobalTracer [baseline] (241.619 ms) : 0, 241619
GlobalTracer [candidate] (244.996 ms) : 0, 244996
AppSec [baseline] (57.263 ms) : 0, 57263
AppSec [candidate] (59.155 ms) : 0, 59155
Debugger [baseline] (7.046 ms) : 0, 7046
Debugger [candidate] (7.024 ms) : 0, 7024
Remote Config [baseline] (683.767 µs) : 0, 684
Remote Config [candidate] (673.941 µs) : 0, 674
Telemetry [baseline] (11.17 ms) : 0, 11170
Telemetry [candidate] (9.054 ms) : 0, 9054
section iast
BytebuddyAgent [baseline] (811.785 ms) : 0, 811785
BytebuddyAgent [candidate] (813.317 ms) : 0, 813317
GlobalTracer [baseline] (232.96 ms) : 0, 232960
GlobalTracer [candidate] (233.958 ms) : 0, 233958
IAST [baseline] (28.781 ms) : 0, 28781
IAST [candidate] (28.893 ms) : 0, 28893
AppSec [baseline] (51.074 ms) : 0, 51074
AppSec [candidate] (50.94 ms) : 0, 50940
Debugger [baseline] (5.945 ms) : 0, 5945
Debugger [candidate] (5.995 ms) : 0, 5995
Remote Config [baseline] (619.469 µs) : 0, 619
Remote Config [candidate] (620.212 µs) : 0, 620
Telemetry [baseline] (8.012 ms) : 0, 8012
Telemetry [candidate] (8.182 ms) : 0, 8182
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032949
Total [baseline] (10.578 s) : 0, 10578331
Agent [candidate] (1.03 s) : 0, 1029508
Total [candidate] (10.556 s) : 0, 10555913
section appsec
Agent [baseline] (1.176 s) : 0, 1176190
Total [baseline] (10.757 s) : 0, 10756889
Agent [candidate] (1.194 s) : 0, 1194240
Total [candidate] (10.757 s) : 0, 10757238
section iast
Agent [baseline] (1.155 s) : 0, 1155062
Total [baseline] (10.87 s) : 0, 10869898
Agent [candidate] (1.161 s) : 0, 1161143
Total [candidate] (10.91 s) : 0, 10910156
section profiling
Agent [baseline] (1.274 s) : 0, 1273790
Total [baseline] (11.01 s) : 0, 11009559
Agent [candidate] (1.276 s) : 0, 1275790
Total [candidate] (10.933 s) : 0, 10933449
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.237 ms) : 0, 692237
BytebuddyAgent [candidate] (690.025 ms) : 0, 690025
GlobalTracer [baseline] (245.038 ms) : 0, 245038
GlobalTracer [candidate] (242.672 ms) : 0, 242672
AppSec [baseline] (57.813 ms) : 0, 57813
AppSec [candidate] (57.82 ms) : 0, 57820
Debugger [baseline] (7.034 ms) : 0, 7034
Debugger [candidate] (6.2 ms) : 0, 6200
Remote Config [baseline] (696.063 µs) : 0, 696
Remote Config [candidate] (661.165 µs) : 0, 661
Telemetry [baseline] (9.06 ms) : 0, 9060
Telemetry [candidate] (11.139 ms) : 0, 11139
section appsec
BytebuddyAgent [baseline] (706.697 ms) : 0, 706697
BytebuddyAgent [candidate] (719.217 ms) : 0, 719217
GlobalTracer [baseline] (234.502 ms) : 0, 234502
GlobalTracer [candidate] (238.15 ms) : 0, 238150
IAST [baseline] (21.852 ms) : 0, 21852
IAST [candidate] (22.328 ms) : 0, 22328
AppSec [baseline] (178.743 ms) : 0, 178743
AppSec [candidate] (179.617 ms) : 0, 179617
Debugger [baseline] (5.755 ms) : 0, 5755
Debugger [candidate] (5.861 ms) : 0, 5861
Remote Config [baseline] (603.728 µs) : 0, 604
Remote Config [candidate] (615.36 µs) : 0, 615
Telemetry [baseline] (7.269 ms) : 0, 7269
Telemetry [candidate] (7.405 ms) : 0, 7405
section iast
BytebuddyAgent [baseline] (807.741 ms) : 0, 807741
BytebuddyAgent [candidate] (812.675 ms) : 0, 812675
GlobalTracer [baseline] (232.579 ms) : 0, 232579
GlobalTracer [candidate] (233.131 ms) : 0, 233131
IAST [baseline] (28.425 ms) : 0, 28425
IAST [candidate] (26.933 ms) : 0, 26933
AppSec [baseline] (50.793 ms) : 0, 50793
AppSec [candidate] (52.759 ms) : 0, 52759
Debugger [baseline] (5.954 ms) : 0, 5954
Debugger [candidate] (5.938 ms) : 0, 5938
Remote Config [baseline] (620.224 µs) : 0, 620
Remote Config [candidate] (619.09 µs) : 0, 619
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (8.063 ms) : 0, 8063
section profiling
BytebuddyAgent [baseline] (676.844 ms) : 0, 676844
BytebuddyAgent [candidate] (681.507 ms) : 0, 681507
GlobalTracer [baseline] (362.842 ms) : 0, 362842
GlobalTracer [candidate] (362.8 ms) : 0, 362800
AppSec [baseline] (62.471 ms) : 0, 62471
AppSec [candidate] (62.275 ms) : 0, 62275
Debugger [baseline] (6.206 ms) : 0, 6206
Debugger [candidate] (6.159 ms) : 0, 6159
Remote Config [baseline] (703.3 µs) : 0, 703
Remote Config [candidate] (698.006 µs) : 0, 698
Telemetry [baseline] (8.239 ms) : 0, 8239
Telemetry [candidate] (8.131 ms) : 0, 8131
ProfilingAgent [baseline] (107.877 ms) : 0, 107877
ProfilingAgent [candidate] (105.33 ms) : 0, 105330
Profiling [baseline] (107.901 ms) : 0, 107901
Profiling [candidate] (105.354 ms) : 0, 105354
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section baseline
no_agent (4.343 ms) : 4292, 4394
. : milestone, 4343,
iast (9.286 ms) : 9135, 9436
. : milestone, 9286,
iast_FULL (13.709 ms) : 13444, 13974
. : milestone, 13709,
iast_GLOBAL (10.17 ms) : 9993, 10346
. : milestone, 10170,
profiling (8.55 ms) : 8418, 8682
. : milestone, 8550,
tracing (7.837 ms) : 7725, 7949
. : milestone, 7837,
section candidate
no_agent (4.355 ms) : 4295, 4416
. : milestone, 4355,
iast (8.903 ms) : 8756, 9051
. : milestone, 8903,
iast_FULL (13.804 ms) : 13532, 14075
. : milestone, 13804,
iast_GLOBAL (9.831 ms) : 9662, 10000
. : milestone, 9831,
profiling (8.679 ms) : 8549, 8809
. : milestone, 8679,
tracing (7.702 ms) : 7580, 7824
. : milestone, 7702,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section baseline
no_agent (37.72 ms) : 37413, 38028
. : milestone, 37720,
appsec (47.305 ms) : 46906, 47704
. : milestone, 47305,
code_origins (42.853 ms) : 42505, 43201
. : milestone, 42853,
iast (45.072 ms) : 44704, 45440
. : milestone, 45072,
profiling (48.783 ms) : 48345, 49221
. : milestone, 48783,
tracing (43.879 ms) : 43522, 44236
. : milestone, 43879,
section candidate
no_agent (36.374 ms) : 36081, 36668
. : milestone, 36374,
appsec (47.384 ms) : 46963, 47805
. : milestone, 47384,
code_origins (46.523 ms) : 46160, 46886
. : milestone, 46523,
iast (44.488 ms) : 44104, 44872
. : milestone, 44488,
profiling (48.55 ms) : 48096, 49005
. : milestone, 48550,
tracing (41.732 ms) : 41400, 42064
. : milestone, 41732,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section baseline
no_agent (15.73 s) : 15730000, 15730000
. : milestone, 15730000,
appsec (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
iast (18.536 s) : 18536000, 18536000
. : milestone, 18536000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
. : milestone, 17919000,
profiling (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
tracing (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
section candidate
no_agent (15.547 s) : 15547000, 15547000
. : milestone, 15547000,
appsec (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
iast (19.05 s) : 19050000, 19050000
. : milestone, 19050000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
profiling (15.349 s) : 15349000, 15349000
. : milestone, 15349000,
tracing (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d5eeb4d0d4, baseline=1.51.0-SNAPSHOT~8e587850a2
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.396 ms) : 2348, 2444
. : milestone, 2396,
iast (2.195 ms) : 2134, 2257
. : milestone, 2195,
iast_GLOBAL (2.23 ms) : 2168, 2291
. : milestone, 2230,
profiling (2.039 ms) : 1989, 2089
. : milestone, 2039,
tracing (2.004 ms) : 1957, 2051
. : milestone, 2004,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (2.403 ms) : 2355, 2452
. : milestone, 2403,
iast (2.192 ms) : 2131, 2253
. : milestone, 2192,
iast_GLOBAL (2.227 ms) : 2166, 2289
. : milestone, 2227,
profiling (2.025 ms) : 1977, 2074
. : milestone, 2025,
tracing (2.012 ms) : 1965, 2060
. : milestone, 2012,
|
ad0bc38
to
7c8620c
Compare
jandro996
approved these changes
Jun 23, 2025
7c8620c
to
6a23408
Compare
6a23408
to
d5eeb4d
Compare
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jul 10, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.39.0` -> `2.40.0` | | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf/commons-lang.git)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.17.0` -> `3.18.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `0.18.0` -> `0.18.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.50.1` -> `1.51.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.40.0`](https://github.com/google/error-prone/releases/tag/v2.40.0): Error Prone 2.40.0 Changes: - Bug fixes and improvements - Releases (including snapshots) have migrated from [OSSRH to the Central Publisher Portal](https://central.sonatype.org/pages/ossrh-eol/#process-to-migrate) Full changelog: google/error-prone@v2.39.0...v2.40.0 </details> <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.18.1`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.18.1) [Compare Source](Kotlin/binary-compatibility-validator@0.18.0...0.18.1) #### What's Changed - Fixed a bug preventing use of cross-compilation support during KLIB dump validation \[[#​304](https://github.com/Kotlin/binary-compatibility-validator/issues/304)]\[[#​306](https://github.com/Kotlin/binary-compatibility-validator/issues/306)] </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.0): 1.51.0 ### Components #### Application Security Management (IAST) - 🐛 Fix verify error when ctor params are used after a call site ([#​9083](DataDog/dd-trace-java#9083) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Limit the maximum size of the location path in IAST vulnerabilities ([#​9028](DataDog/dd-trace-java#9028) - [@​jandro996](https://github.com/jandro996)) - 🐛 Fix IAST gRPC handler with null superclass ([#​8984](DataDog/dd-trace-java#8984) - [@​smola](https://github.com/smola)) - ✨ Optimize IAST Vulnerability Detection ([#​8885](DataDog/dd-trace-java#8885) - [@​jandro996](https://github.com/jandro996)) #### Application Security Management (WAF) - ✨ Upgrade libddwaf-java to 15.0.0 ([#​9022](DataDog/dd-trace-java#9022) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Extract RestEasy json body response schemas ([#​9015](DataDog/dd-trace-java#9015) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract Jersey json body response schemas ([#​9014](DataDog/dd-trace-java#9014) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract Ratpack json body response schemas ([#​9013](DataDog/dd-trace-java#9013) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Enable API Security by default and make it lazy loading ([#​9009](DataDog/dd-trace-java#9009) - [@​smola](https://github.com/smola)) - ✨ Extract Vert.x json body response schemas ([#​9001](DataDog/dd-trace-java#9001) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Play json body response schemas ([#​8995](DataDog/dd-trace-java#8995) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix Jackson nodes introspection for request/response schema extraction ([#​8980](DataDog/dd-trace-java#8980) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Spring json body response schemas ([#​8938](DataDog/dd-trace-java#8938) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Default obfuscation regexp update ([#​8937](DataDog/dd-trace-java#8937) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Build & Tooling - ✨ Cancel GitLab running pipeline on new PR push ([#​9023](DataDog/dd-trace-java#9023) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Migrate publishing to Maven Central Portal ([#​8807](DataDog/dd-trace-java#8807) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - 🐛 Fix Test Optimization to work with JDK 24 ([#​9114](DataDog/dd-trace-java#9114) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add repo root as safe directory on git client creation ([#​9033](DataDog/dd-trace-java#9033) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add PR number tag and improve PR information building ([#​8990](DataDog/dd-trace-java#8990) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update impacted tests logic ([#​8923](DataDog/dd-trace-java#8923) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 🧹 Clean up DSM context injection ([#​8776](DataDog/dd-trace-java#8776) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Database Monitoring - 🐛 Set trace\_injected in try block ([#​9025](DataDog/dd-trace-java#9025) - [@​natashadada](https://github.com/natashadada)) #### Dynamic Instrumentation - 🐛 Add source file tracking enable option ([#​9115](DataDog/dd-trace-java#9115) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add java.util.Date support ([#​9111](DataDog/dd-trace-java#9111) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Update file probe format ([#​9047](DataDog/dd-trace-java#9047) - [@​jpbempel](https://github.com/jpbempel)) - ✨ add safe local var hoisting ([#​9034](DataDog/dd-trace-java#9034) - [@​jpbempel](https://github.com/jpbempel)) - 🧹 Add new config for debugger upload interval ([#​8959](DataDog/dd-trace-java#8959) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Enable Code Origin with Dynamic instrumentation ([#​8940](DataDog/dd-trace-java#8940) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - 💡 LLM Observability SDK ([#​8781](DataDog/dd-trace-java#8781) - [@​gary-huang](https://github.com/gary-huang), [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - 🐛 Ensure client stat reporter is started when the agent is not available at bootstrap ([#​9082](DataDog/dd-trace-java#9082) - [@​amarziali](https://github.com/amarziali)) - ✨ Create metric: appsec.waf.config\_errors ([#​8394](DataDog/dd-trace-java#8394) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Platform components - ✨ Introduce environment component ([#​9071](DataDog/dd-trace-java#9071) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - 🐛 Remove annoying warning for smap event parsing ([#​9119](DataDog/dd-trace-java#9119) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Fix ByteCountingInputStream when reading past EOF ([#​8988](DataDog/dd-trace-java#8988) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Realtime User Monitoring - ✨ Add RUM SDK injection for servlet based web servers ([#​9110](DataDog/dd-trace-java#9110) - [@​PerfectSlayer](https://github.com/PerfectSlayer) [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Update the config origin metric to match what it's mapping ([#​9045](DataDog/dd-trace-java#9045) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Testing - ✨ Add testing for latest stable version (JDK 24) ([#​8875](DataDog/dd-trace-java#8875) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Fix bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` ([#​9037](DataDog/dd-trace-java#9037) - [@​mhlidd](https://github.com/mhlidd)) - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#​9032](DataDog/dd-trace-java#9032) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Fix `Error` handling for trace interceptors ([#​9097](DataDog/dd-trace-java#9097) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add wildcard feature for `DD_TRACE_HEADER_TAGS` and enabling for Http Response headers ([#​9067](DataDog/dd-trace-java#9067) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer public API - 💡 Add LLM Observability SDK ([#​8781](DataDog/dd-trace-java#8781) - [@​gary-huang](https://github.com/gary-huang)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#​9019](DataDog/dd-trace-java#9019) - [@​mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - ✨ Extract Vert.x json body response schemas ([#​9001](DataDog/dd-trace-java#9001) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Write http.route tag as soon as possible in vert.x ([#​8952](DataDog/dd-trace-java#8952) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### JAX-WS instrumentation - 💡⚠️ Enable jax-ws integration by default ([#​9030](DataDog/dd-trace-java#9030) - [@​bm1549](https://github.com/bm1549)) - ✨ Extract Jersey json body response schemas ([#​9014](DataDog/dd-trace-java#9014) - [@​jandro996](https://github.com/jandro996)) #### Mule instrumentation - 🐛 Propagate grizzly http span in filters if nothing is active ([#​9016](DataDog/dd-trace-java#9016) - [@​amarziali](https://github.com/amarziali)) #### Play Framework instrumentation - ✨ Extract Play json body response schemas ([#​8995](DataDog/dd-trace-java#8995) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Ratpack instrumentation - ✨ Extract Ratpack json body response schemas ([#​9013](DataDog/dd-trace-java#9013) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Spring instrumentation - ✨ Extract Spring json body response schemas ([#​8938](DataDog/dd-trace-java#8938) - [@​sezen-datadog](https://github.com/sezen-datadog)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 649b690d4c9d7dcb572c457f0802b42b8e3e682e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Writes the http.route tag as soon as possible in Vert.x instead of waiting until the end of the request.
Motivation
API security needs access to the current route in order to make its sampling decision when extracting request/response schemas. Current implementation delays the computing of the route until the end of the request which is too late causing all requests to be sampled out.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-56870 APPSEC-56871