-
Notifications
You must be signed in to change notification settings - Fork 305
Mute tracing for subprocesses executed by bootstrap telemetry logic. #9005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1002246
Total [baseline] (10.647 s) : 0, 10647162
Agent [candidate] (999.319 ms) : 0, 999319
Total [candidate] (10.644 s) : 0, 10643757
section appsec
Agent [baseline] (1.176 s) : 0, 1175595
Total [baseline] (10.763 s) : 0, 10762572
Agent [candidate] (1.177 s) : 0, 1177096
Total [candidate] (10.738 s) : 0, 10737941
section iast
Agent [baseline] (1.143 s) : 0, 1142877
Total [baseline] (10.853 s) : 0, 10852530
Agent [candidate] (1.136 s) : 0, 1136491
Total [candidate] (10.829 s) : 0, 10828596
section profiling
Agent [baseline] (1.245 s) : 0, 1245201
Total [baseline] (10.96 s) : 0, 10959784
Agent [candidate] (1.248 s) : 0, 1248291
Total [candidate] (10.958 s) : 0, 10958419
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.53 ms) : 0, 692530
BytebuddyAgent [candidate] (690.213 ms) : 0, 690213
GlobalTracer [baseline] (243.425 ms) : 0, 243425
GlobalTracer [candidate] (242.8 ms) : 0, 242800
AppSec [baseline] (30.37 ms) : 0, 30370
AppSec [candidate] (30.317 ms) : 0, 30317
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (685.486 µs) : 0, 685
Remote Config [candidate] (678.226 µs) : 0, 678
Telemetry [baseline] (8.216 ms) : 0, 8216
Telemetry [candidate] (8.248 ms) : 0, 8248
section appsec
BytebuddyAgent [baseline] (710.205 ms) : 0, 710205
BytebuddyAgent [candidate] (711.303 ms) : 0, 711303
GlobalTracer [baseline] (235.22 ms) : 0, 235220
GlobalTracer [candidate] (235.63 ms) : 0, 235630
IAST [baseline] (23.332 ms) : 0, 23332
IAST [candidate] (23.359 ms) : 0, 23359
AppSec [baseline] (171.73 ms) : 0, 171730
AppSec [candidate] (171.619 ms) : 0, 171619
Debugger [baseline] (5.719 ms) : 0, 5719
Debugger [candidate] (5.716 ms) : 0, 5716
Remote Config [baseline] (598.198 µs) : 0, 598
Remote Config [candidate] (606.455 µs) : 0, 606
Telemetry [baseline] (7.985 ms) : 0, 7985
Telemetry [candidate] (8.001 ms) : 0, 8001
section iast
BytebuddyAgent [baseline] (815.048 ms) : 0, 815048
BytebuddyAgent [candidate] (809.706 ms) : 0, 809706
GlobalTracer [baseline] (234.888 ms) : 0, 234888
GlobalTracer [candidate] (233.818 ms) : 0, 233818
IAST [baseline] (28.652 ms) : 0, 28652
IAST [candidate] (25.602 ms) : 0, 25602
AppSec [baseline] (28.792 ms) : 0, 28792
AppSec [candidate] (31.93 ms) : 0, 31930
Debugger [baseline] (5.869 ms) : 0, 5869
Debugger [candidate] (5.89 ms) : 0, 5890
Remote Config [baseline] (591.234 µs) : 0, 591
Remote Config [candidate] (587.519 µs) : 0, 588
Telemetry [baseline] (8.083 ms) : 0, 8083
Telemetry [candidate] (8.097 ms) : 0, 8097
section profiling
BytebuddyAgent [baseline] (678.517 ms) : 0, 678517
BytebuddyAgent [candidate] (680.529 ms) : 0, 680529
GlobalTracer [baseline] (361.792 ms) : 0, 361792
GlobalTracer [candidate] (362.296 ms) : 0, 362296
AppSec [baseline] (31.517 ms) : 0, 31517
AppSec [candidate] (33.138 ms) : 0, 33138
Debugger [baseline] (12.798 ms) : 0, 12798
Debugger [candidate] (10.794 ms) : 0, 10794
Remote Config [baseline] (664.495 µs) : 0, 664
Remote Config [candidate] (665.229 µs) : 0, 665
Telemetry [baseline] (7.982 ms) : 0, 7982
Telemetry [candidate] (8.834 ms) : 0, 8834
ProfilingAgent [baseline] (103.181 ms) : 0, 103181
ProfilingAgent [candidate] (103.066 ms) : 0, 103066
Profiling [baseline] (103.207 ms) : 0, 103207
Profiling [candidate] (103.09 ms) : 0, 103090
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016889
Total [baseline] (8.692 s) : 0, 8691626
Agent [candidate] (1.002 s) : 0, 1002067
Total [candidate] (8.588 s) : 0, 8587815
section iast
Agent [baseline] (1.138 s) : 0, 1137678
Total [baseline] (9.33 s) : 0, 9330258
Agent [candidate] (1.136 s) : 0, 1136304
Total [candidate] (9.303 s) : 0, 9303192
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (704.012 ms) : 0, 704012
BytebuddyAgent [candidate] (692.329 ms) : 0, 692329
GlobalTracer [baseline] (245.669 ms) : 0, 245669
GlobalTracer [candidate] (243.238 ms) : 0, 243238
AppSec [baseline] (30.78 ms) : 0, 30780
AppSec [candidate] (30.536 ms) : 0, 30536
Debugger [baseline] (6.157 ms) : 0, 6157
Debugger [candidate] (6.094 ms) : 0, 6094
Remote Config [baseline] (693.496 µs) : 0, 693
Remote Config [candidate] (678.909 µs) : 0, 679
Telemetry [baseline] (8.432 ms) : 0, 8432
Telemetry [candidate] (8.301 ms) : 0, 8301
section iast
BytebuddyAgent [baseline] (809.283 ms) : 0, 809283
BytebuddyAgent [candidate] (810.813 ms) : 0, 810813
GlobalTracer [baseline] (234.755 ms) : 0, 234755
GlobalTracer [candidate] (233.383 ms) : 0, 233383
IAST [baseline] (25.681 ms) : 0, 25681
IAST [candidate] (29.315 ms) : 0, 29315
AppSec [baseline] (30.838 ms) : 0, 30838
AppSec [candidate] (27.559 ms) : 0, 27559
Debugger [baseline] (6.693 ms) : 0, 6693
Debugger [candidate] (5.805 ms) : 0, 5805
Remote Config [baseline] (590.049 µs) : 0, 590
Remote Config [candidate] (575.251 µs) : 0, 575
Telemetry [baseline] (8.167 ms) : 0, 8167
Telemetry [candidate] (7.998 ms) : 0, 7998
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section baseline
no_agent (4.303 ms) : 4248, 4359
. : milestone, 4303,
iast (9.536 ms) : 9382, 9691
. : milestone, 9536,
iast_FULL (14.092 ms) : 13807, 14376
. : milestone, 14092,
iast_GLOBAL (9.959 ms) : 9786, 10131
. : milestone, 9959,
profiling (8.862 ms) : 8725, 9000
. : milestone, 8862,
tracing (7.465 ms) : 7354, 7575
. : milestone, 7465,
section candidate
no_agent (4.309 ms) : 4253, 4365
. : milestone, 4309,
iast (9.301 ms) : 9149, 9452
. : milestone, 9301,
iast_FULL (13.948 ms) : 13675, 14220
. : milestone, 13948,
iast_GLOBAL (10.276 ms) : 10073, 10479
. : milestone, 10276,
profiling (8.637 ms) : 8503, 8771
. : milestone, 8637,
tracing (7.697 ms) : 7581, 7813
. : milestone, 7697,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section baseline
no_agent (37.511 ms) : 37209, 37812
. : milestone, 37511,
appsec (47.955 ms) : 47528, 48382
. : milestone, 47955,
code_origins (45.785 ms) : 45381, 46188
. : milestone, 45785,
iast (45.707 ms) : 45287, 46127
. : milestone, 45707,
profiling (50.053 ms) : 49549, 50558
. : milestone, 50053,
tracing (41.986 ms) : 41642, 42329
. : milestone, 41986,
section candidate
no_agent (35.826 ms) : 35545, 36108
. : milestone, 35826,
appsec (47.551 ms) : 47125, 47977
. : milestone, 47551,
code_origins (43.54 ms) : 43162, 43918
. : milestone, 43540,
iast (43.681 ms) : 43296, 44067
. : milestone, 43681,
profiling (48.191 ms) : 47714, 48668
. : milestone, 48191,
tracing (41.984 ms) : 41645, 42323
. : milestone, 41984,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.4 ms) : 2351, 2450
. : milestone, 2400,
iast (2.187 ms) : 2125, 2248
. : milestone, 2187,
iast_GLOBAL (2.23 ms) : 2167, 2292
. : milestone, 2230,
profiling (2.027 ms) : 1978, 2077
. : milestone, 2027,
tracing (2.01 ms) : 1962, 2058
. : milestone, 2010,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.408 ms) : 2358, 2457
. : milestone, 2408,
iast (2.192 ms) : 2130, 2254
. : milestone, 2192,
iast_GLOBAL (2.236 ms) : 2173, 2298
. : milestone, 2236,
profiling (2.051 ms) : 2000, 2102
. : milestone, 2051,
tracing (2.016 ms) : 1968, 2065
. : milestone, 2016,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8ba526acdb, baseline=1.51.0-SNAPSHOT~5d247c5f5e
dateFormat X
axisFormat %s
section baseline
no_agent (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
appsec (14.576 s) : 14576000, 14576000
. : milestone, 14576000,
iast (18.454 s) : 18454000, 18454000
. : milestone, 18454000,
iast_GLOBAL (17.757 s) : 17757000, 17757000
. : milestone, 17757000,
profiling (15.356 s) : 15356000, 15356000
. : milestone, 15356000,
tracing (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
section candidate
no_agent (15.516 s) : 15516000, 15516000
. : milestone, 15516000,
appsec (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
iast (18.591 s) : 18591000, 18591000
. : milestone, 18591000,
iast_GLOBAL (18.069 s) : 18069000, 18069000
. : milestone, 18069000,
profiling (15.377 s) : 15377000, 15377000
. : milestone, 15377000,
tracing (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
|
…ry forwarder sub-process any more.
@@ -221,5 +223,19 @@ public void run() { | |||
System.err.println("Failed to send telemetry: " + e.getMessage()); | |||
} | |||
} | |||
|
|||
@SuppressForbidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice solution
What Does This Do
The bootstrap logic runs external process to forward some initial telemetry. The subprocess instrumentation creates span for this which may be confusing to users.
Motivation
Reduce noise for the end user.
Additional Notes
We have similar logic in couple of other places, see #6584 as example.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]