-
Notifications
You must be signed in to change notification settings - Fork 305
Extract Ratpack json body response schemas #9013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Ratpack json body response schemas #9013
Conversation
686764c
to
7e087e5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001492
Total [baseline] (10.817 s) : 0, 10816517
Agent [candidate] (1.005 s) : 0, 1005367
Total [candidate] (10.739 s) : 0, 10738985
section appsec
Agent [baseline] (1.184 s) : 0, 1184059
Total [baseline] (10.809 s) : 0, 10808818
Agent [candidate] (1.184 s) : 0, 1184267
Total [candidate] (10.753 s) : 0, 10753165
section iast
Agent [baseline] (1.134 s) : 0, 1134483
Total [baseline] (10.815 s) : 0, 10815176
Agent [candidate] (1.135 s) : 0, 1135477
Total [candidate] (10.876 s) : 0, 10875971
section profiling
Agent [baseline] (1.249 s) : 0, 1248607
Total [baseline] (11.204 s) : 0, 11204232
Agent [candidate] (1.246 s) : 0, 1246437
Total [candidate] (10.919 s) : 0, 10918608
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.023 ms) : 0, 690023
BytebuddyAgent [candidate] (694.072 ms) : 0, 694072
GlobalTracer [baseline] (244.671 ms) : 0, 244671
GlobalTracer [candidate] (244.497 ms) : 0, 244497
AppSec [baseline] (30.678 ms) : 0, 30678
AppSec [candidate] (30.711 ms) : 0, 30711
Debugger [baseline] (6.131 ms) : 0, 6131
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (688.534 µs) : 0, 689
Remote Config [candidate] (678.685 µs) : 0, 679
Telemetry [baseline] (8.367 ms) : 0, 8367
Telemetry [candidate] (8.3 ms) : 0, 8300
section appsec
BytebuddyAgent [baseline] (717.309 ms) : 0, 717309
BytebuddyAgent [candidate] (717.558 ms) : 0, 717558
GlobalTracer [baseline] (237.9 ms) : 0, 237900
GlobalTracer [candidate] (237.897 ms) : 0, 237897
AppSec [baseline] (170.848 ms) : 0, 170848
AppSec [candidate] (170.937 ms) : 0, 170937
Debugger [baseline] (5.828 ms) : 0, 5828
Debugger [candidate] (5.824 ms) : 0, 5824
Remote Config [baseline] (617.182 µs) : 0, 617
Remote Config [candidate] (625.837 µs) : 0, 626
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.196 ms) : 0, 8196
IAST [baseline] (22.338 ms) : 0, 22338
IAST [candidate] (22.273 ms) : 0, 22273
section iast
BytebuddyAgent [baseline] (809.853 ms) : 0, 809853
BytebuddyAgent [candidate] (810.66 ms) : 0, 810660
GlobalTracer [baseline] (233.877 ms) : 0, 233877
GlobalTracer [candidate] (233.581 ms) : 0, 233581
AppSec [baseline] (29.252 ms) : 0, 29252
AppSec [candidate] (29.535 ms) : 0, 29535
Debugger [baseline] (5.819 ms) : 0, 5819
Debugger [candidate] (5.794 ms) : 0, 5794
Remote Config [baseline] (580.94 µs) : 0, 581
Remote Config [candidate] (579.936 µs) : 0, 580
Telemetry [baseline] (7.941 ms) : 0, 7941
Telemetry [candidate] (7.957 ms) : 0, 7957
IAST [baseline] (26.262 ms) : 0, 26262
IAST [candidate] (26.409 ms) : 0, 26409
section profiling
BytebuddyAgent [baseline] (678.723 ms) : 0, 678723
BytebuddyAgent [candidate] (679.043 ms) : 0, 679043
GlobalTracer [baseline] (363.606 ms) : 0, 363606
GlobalTracer [candidate] (361.924 ms) : 0, 361924
AppSec [baseline] (33.279 ms) : 0, 33279
AppSec [candidate] (30.888 ms) : 0, 30888
Debugger [baseline] (9.912 ms) : 0, 9912
Debugger [candidate] (12.176 ms) : 0, 12176
Remote Config [baseline] (1.434 ms) : 0, 1434
Remote Config [candidate] (654.373 µs) : 0, 654
Telemetry [baseline] (8.894 ms) : 0, 8894
Telemetry [candidate] (8.839 ms) : 0, 8839
ProfilingAgent [baseline] (103.933 ms) : 0, 103933
ProfilingAgent [candidate] (103.346 ms) : 0, 103346
Profiling [baseline] (103.959 ms) : 0, 103959
Profiling [candidate] (103.371 ms) : 0, 103371
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006308
Total [baseline] (8.599 s) : 0, 8598938
Agent [candidate] (999.423 ms) : 0, 999423
Total [candidate] (8.571 s) : 0, 8570738
section iast
Agent [baseline] (1.135 s) : 0, 1135467
Total [baseline] (9.282 s) : 0, 9282105
Agent [candidate] (1.139 s) : 0, 1139450
Total [candidate] (9.299 s) : 0, 9299216
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.132 ms) : 0, 696132
BytebuddyAgent [candidate] (689.329 ms) : 0, 689329
GlobalTracer [baseline] (243.525 ms) : 0, 243525
GlobalTracer [candidate] (243.809 ms) : 0, 243809
AppSec [baseline] (30.62 ms) : 0, 30620
AppSec [candidate] (30.352 ms) : 0, 30352
Debugger [baseline] (6.09 ms) : 0, 6090
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (674.071 µs) : 0, 674
Remote Config [candidate] (668.812 µs) : 0, 669
Telemetry [baseline] (8.254 ms) : 0, 8254
Telemetry [candidate] (8.273 ms) : 0, 8273
section iast
BytebuddyAgent [baseline] (812.263 ms) : 0, 812263
BytebuddyAgent [candidate] (814.417 ms) : 0, 814417
GlobalTracer [baseline] (232.472 ms) : 0, 232472
GlobalTracer [candidate] (234.425 ms) : 0, 234425
AppSec [baseline] (26.992 ms) : 0, 26992
AppSec [candidate] (25.929 ms) : 0, 25929
Debugger [baseline] (5.842 ms) : 0, 5842
Debugger [candidate] (5.821 ms) : 0, 5821
Remote Config [baseline] (586.512 µs) : 0, 587
Remote Config [candidate] (583.073 µs) : 0, 583
Telemetry [baseline] (7.93 ms) : 0, 7930
Telemetry [candidate] (7.883 ms) : 0, 7883
IAST [baseline] (28.619 ms) : 0, 28619
IAST [candidate] (29.54 ms) : 0, 29540
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section baseline
no_agent (37.14 ms) : 36835, 37445
. : milestone, 37140,
appsec (48.119 ms) : 47686, 48553
. : milestone, 48119,
code_origins (43.051 ms) : 42701, 43401
. : milestone, 43051,
iast (43.425 ms) : 43037, 43814
. : milestone, 43425,
profiling (49.94 ms) : 49466, 50414
. : milestone, 49940,
tracing (42.746 ms) : 42381, 43110
. : milestone, 42746,
section candidate
no_agent (36.807 ms) : 36520, 37095
. : milestone, 36807,
appsec (47.434 ms) : 47011, 47857
. : milestone, 47434,
code_origins (44.731 ms) : 44375, 45086
. : milestone, 44731,
iast (42.104 ms) : 41748, 42460
. : milestone, 42104,
profiling (47.224 ms) : 46815, 47634
. : milestone, 47224,
tracing (43.126 ms) : 42775, 43477
. : milestone, 43126,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section baseline
no_agent (4.381 ms) : 4331, 4431
. : milestone, 4381,
iast (9.271 ms) : 9112, 9430
. : milestone, 9271,
iast_FULL (13.445 ms) : 13184, 13706
. : milestone, 13445,
iast_GLOBAL (10.065 ms) : 9886, 10244
. : milestone, 10065,
profiling (9.11 ms) : 8958, 9263
. : milestone, 9110,
tracing (7.87 ms) : 7749, 7991
. : milestone, 7870,
section candidate
no_agent (4.487 ms) : 4435, 4539
. : milestone, 4487,
iast (9.375 ms) : 9223, 9527
. : milestone, 9375,
iast_FULL (13.681 ms) : 13415, 13947
. : milestone, 13681,
iast_GLOBAL (10.243 ms) : 10059, 10426
. : milestone, 10243,
profiling (8.574 ms) : 8441, 8707
. : milestone, 8574,
tracing (7.536 ms) : 7429, 7644
. : milestone, 7536,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.406 ms) : 2358, 2455
. : milestone, 2406,
iast (2.188 ms) : 2127, 2250
. : milestone, 2188,
iast_GLOBAL (2.235 ms) : 2173, 2297
. : milestone, 2235,
profiling (2.051 ms) : 2001, 2101
. : milestone, 2051,
tracing (2.012 ms) : 1965, 2060
. : milestone, 2012,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.413 ms) : 2364, 2462
. : milestone, 2413,
iast (2.185 ms) : 2123, 2246
. : milestone, 2185,
iast_GLOBAL (2.234 ms) : 2172, 2296
. : milestone, 2234,
profiling (2.039 ms) : 1989, 2088
. : milestone, 2039,
tracing (2.014 ms) : 1967, 2062
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d9a0fb0e76, baseline=1.51.0-SNAPSHOT~becbf2a03c
dateFormat X
axisFormat %s
section baseline
no_agent (15.494 s) : 15494000, 15494000
. : milestone, 15494000,
appsec (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
iast (18.514 s) : 18514000, 18514000
. : milestone, 18514000,
iast_GLOBAL (17.918 s) : 17918000, 17918000
. : milestone, 17918000,
profiling (15.322 s) : 15322000, 15322000
. : milestone, 15322000,
tracing (14.803 s) : 14803000, 14803000
. : milestone, 14803000,
section candidate
no_agent (15.361 s) : 15361000, 15361000
. : milestone, 15361000,
appsec (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
iast (19.163 s) : 19163000, 19163000
. : milestone, 19163000,
iast_GLOBAL (18.169 s) : 18169000, 18169000
. : milestone, 18169000,
profiling (15.835 s) : 15835000, 15835000
. : milestone, 15835000,
tracing (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
|
135e0f0
to
f5b9e7b
Compare
7e087e5
to
244b4d6
Compare
f5b9e7b
to
3fabdcd
Compare
244b4d6
to
ffe6fd3
Compare
fe3ba88
to
22b45ef
Compare
ffe6fd3
to
dfccd9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just one question, Do we only give support to Ratpack 1.5 or grater?
22b45ef
to
ea1aa76
Compare
dfccd9d
to
dd4fbc2
Compare
ea1aa76
to
909e714
Compare
0eb016c
to
7e2e15d
Compare
909e714
to
6bbdb08
Compare
7e2e15d
to
0a6e658
Compare
ed355c7
to
ebaa338
Compare
0a6e658
to
a327867
Compare
Yes, that's the support we have for appsec |
a327867
to
8b84450
Compare
8b84450
to
d9a0fb0
Compare
What Does This Do
Adds response body extraction for Ratpack JSON endpoints to enable automatic API schema discovery and protection by the Web Application Firewall (WAF).
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57915