-
Notifications
You must be signed in to change notification settings - Fork 306
Extract Jersey json body response schemas #9014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jandro996
wants to merge
3
commits into
malvarez/vertx-response-extraction
Choose a base branch
from
alejandro.gonzalez/api-sec-jersey-response-schema
base: malvarez/vertx-response-extraction
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Extract Jersey json body response schemas #9014
jandro996
wants to merge
3
commits into
malvarez/vertx-response-extraction
from
alejandro.gonzalez/api-sec-jersey-response-schema
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c78ad2
to
2aeb457
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 41 metrics, 11 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~db385e8686, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027117
Total [baseline] (8.569 s) : 0, 8569163
Agent [candidate] (1.028 s) : 0, 1028051
Total [candidate] (8.537 s) : 0, 8537472
section iast
Agent [baseline] (1.154 s) : 0, 1154020
Total [baseline] (9.215 s) : 0, 9215124
Agent [candidate] (1.157 s) : 0, 1156924
Total [candidate] (9.247 s) : 0, 9246735
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~db385e8686, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.179 ms) : 0, 687179
BytebuddyAgent [candidate] (684.578 ms) : 0, 684578
GlobalTracer [baseline] (241.508 ms) : 0, 241508
GlobalTracer [candidate] (241.175 ms) : 0, 241175
AppSec [baseline] (57.874 ms) : 0, 57874
AppSec [candidate] (58.595 ms) : 0, 58595
Debugger [baseline] (7.906 ms) : 0, 7906
Debugger [candidate] (6.97 ms) : 0, 6970
Remote Config [baseline] (668.004 µs) : 0, 668
Remote Config [candidate] (673.231 µs) : 0, 673
Telemetry [baseline] (11.121 ms) : 0, 11121
Telemetry [candidate] (12.621 ms) : 0, 12621
section iast
BytebuddyAgent [baseline] (806.986 ms) : 0, 806986
BytebuddyAgent [candidate] (805.408 ms) : 0, 805408
GlobalTracer [baseline] (232.094 ms) : 0, 232094
GlobalTracer [candidate] (231.778 ms) : 0, 231778
AppSec [baseline] (50.748 ms) : 0, 50748
AppSec [candidate] (53.951 ms) : 0, 53951
Debugger [baseline] (5.977 ms) : 0, 5977
Debugger [candidate] (5.968 ms) : 0, 5968
Remote Config [baseline] (601.382 µs) : 0, 601
Remote Config [candidate] (582.435 µs) : 0, 582
Telemetry [baseline] (8.277 ms) : 0, 8277
Telemetry [candidate] (7.877 ms) : 0, 7877
IAST [baseline] (28.551 ms) : 0, 28551
IAST [candidate] (27.893 ms) : 0, 27893
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~db385e8686, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026183
Total [baseline] (10.7 s) : 0, 10699585
Agent [candidate] (1.038 s) : 0, 1037576
Total [candidate] (10.652 s) : 0, 10651639
section appsec
Agent [baseline] (1.2 s) : 0, 1200358
Total [baseline] (10.831 s) : 0, 10831380
Agent [candidate] (1.183 s) : 0, 1182511
Total [candidate] (10.715 s) : 0, 10714984
section iast
Agent [baseline] (1.163 s) : 0, 1162562
Total [baseline] (10.839 s) : 0, 10838545
Agent [candidate] (1.166 s) : 0, 1166335
Total [candidate] (10.925 s) : 0, 10924561
section profiling
Agent [baseline] (1.27 s) : 0, 1270462
Total [baseline] (11.02 s) : 0, 11020423
Agent [candidate] (1.272 s) : 0, 1272447
Total [candidate] (10.893 s) : 0, 10892941
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~db385e8686, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.95 ms) : 0, 686950
BytebuddyAgent [candidate] (691.631 ms) : 0, 691631
GlobalTracer [baseline] (242.125 ms) : 0, 242125
GlobalTracer [candidate] (242.996 ms) : 0, 242996
AppSec [baseline] (59.381 ms) : 0, 59381
AppSec [candidate] (61.977 ms) : 0, 61977
Debugger [baseline] (7.114 ms) : 0, 7114
Debugger [candidate] (6.252 ms) : 0, 6252
Remote Config [baseline] (668.832 µs) : 0, 669
Remote Config [candidate] (680.3 µs) : 0, 680
Telemetry [baseline] (8.999 ms) : 0, 8999
Telemetry [candidate] (10.398 ms) : 0, 10398
section appsec
BytebuddyAgent [baseline] (725.393 ms) : 0, 725393
BytebuddyAgent [candidate] (708.163 ms) : 0, 708163
GlobalTracer [baseline] (240.171 ms) : 0, 240171
GlobalTracer [candidate] (235.59 ms) : 0, 235590
AppSec [baseline] (177.219 ms) : 0, 177219
AppSec [candidate] (179.727 ms) : 0, 179727
Debugger [baseline] (5.984 ms) : 0, 5984
Debugger [candidate] (5.847 ms) : 0, 5847
Remote Config [baseline] (639.468 µs) : 0, 639
Remote Config [candidate] (647.02 µs) : 0, 647
Telemetry [baseline] (7.264 ms) : 0, 7264
Telemetry [candidate] (7.273 ms) : 0, 7273
IAST [baseline] (22.532 ms) : 0, 22532
IAST [candidate] (21.772 ms) : 0, 21772
section iast
BytebuddyAgent [baseline] (813.344 ms) : 0, 813344
BytebuddyAgent [candidate] (811.824 ms) : 0, 811824
GlobalTracer [baseline] (233.815 ms) : 0, 233815
GlobalTracer [candidate] (233.118 ms) : 0, 233118
AppSec [baseline] (53.443 ms) : 0, 53443
AppSec [candidate] (55.833 ms) : 0, 55833
Debugger [baseline] (6.014 ms) : 0, 6014
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (619.088 µs) : 0, 619
Remote Config [candidate] (618.646 µs) : 0, 619
Telemetry [baseline] (8.102 ms) : 0, 8102
Telemetry [candidate] (7.985 ms) : 0, 7985
IAST [baseline] (26.252 ms) : 0, 26252
IAST [candidate] (27.354 ms) : 0, 27354
section profiling
ProfilingAgent [baseline] (105.041 ms) : 0, 105041
ProfilingAgent [candidate] (107.493 ms) : 0, 107493
BytebuddyAgent [baseline] (678.391 ms) : 0, 678391
BytebuddyAgent [candidate] (675.112 ms) : 0, 675112
GlobalTracer [baseline] (361.587 ms) : 0, 361587
GlobalTracer [candidate] (359.288 ms) : 0, 359288
AppSec [baseline] (61.803 ms) : 0, 61803
AppSec [candidate] (64.664 ms) : 0, 64664
Debugger [baseline] (6.136 ms) : 0, 6136
Debugger [candidate] (6.257 ms) : 0, 6257
Remote Config [baseline] (701.369 µs) : 0, 701
Remote Config [candidate] (674.806 µs) : 0, 675
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.245 ms) : 0, 8245
Profiling [baseline] (105.066 ms) : 0, 105066
Profiling [candidate] (107.519 ms) : 0, 107519
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 3 metrics, 8 unstable metrics.
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~db385e8686, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.406 ms) : 2358, 2455
. : milestone, 2406,
iast (2.181 ms) : 2120, 2242
. : milestone, 2181,
iast_GLOBAL (2.233 ms) : 2172, 2295
. : milestone, 2233,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (2.005 ms) : 1958, 2053
. : milestone, 2005,
section candidate
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (2.406 ms) : 2357, 2455
. : milestone, 2406,
iast (2.2 ms) : 2138, 2262
. : milestone, 2200,
iast_GLOBAL (2.229 ms) : 2167, 2291
. : milestone, 2229,
profiling (2.043 ms) : 1993, 2093
. : milestone, 2043,
tracing (2.008 ms) : 1960, 2056
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~db385e8686, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
appsec (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
iast (18.268 s) : 18268000, 18268000
. : milestone, 18268000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
. : milestone, 18053000,
profiling (15.913 s) : 15913000, 15913000
. : milestone, 15913000,
tracing (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
section candidate
no_agent (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
appsec (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
iast (18.921 s) : 18921000, 18921000
. : milestone, 18921000,
iast_GLOBAL (18.228 s) : 18228000, 18228000
. : milestone, 18228000,
profiling (15.332 s) : 15332000, 15332000
. : milestone, 15332000,
tracing (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
inst: jax-ws
JAX-WS instrumentation
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds response body extraction for Jersey JSON endpoints to enable automatic API schema discovery and protection by the Web Application Firewall (WAF).
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]