Skip to content

Fix typo in go get command for orchestrion #29535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented May 26, 2025

What does this PR do? What is the motivation?

Fix a typo

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@KevinFairise2 KevinFairise2 requested review from a team as code owners May 26, 2025 07:52
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KevinFairise2 👋🏻 You might notice that some of the usual automations that happen in docs PRs haven't run for this one, and that's because your branch name doesn't have a slash in it. The easiest way around this is typically to close your PR, rename your branch to fulfill the requirements we list in the "For Datadog employees" section above, and then open a new one. Then we can get this approved and published using those automations.

Sorry for the inconvenience (especially for such a minor PR), and let me know if you have any questions!

@KevinFairise2
Copy link
Member Author

Hey @KevinFairise2 👋🏻 You might notice that some of the usual automations that happen in docs PRs haven't run for this one, and that's because your branch name doesn't have a slash in it. The easiest way around this is typically to close your PR, rename your branch to fulfill the requirements we list in the "For Datadog employees" section above, and then open a new one. Then we can get this approved and published using those automations.

Sorry for the inconvenience (especially for such a minor PR), and let me know if you have any questions!

Oh I see, I must admit I opened the PR through Github UI and did not pay attention to update the branch name.
I just reopened a new one with a name that should work.
#29547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants