-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update X-Ray guide to better compare Datadog APM & AWS X-Ray #29549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
avedmala
wants to merge
14
commits into
master
Choose a base branch
from
avedmala/xray
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d AWS X-Ray Restructured the guide to help users decide when to use Datadog APM vs AWS X-Ray for serverless tracing. Added comprehensive comparison sections covering limitations, advantages, and use cases for both solutions. Moved technical setup instructions to the end while maintaining all existing functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Preview links (active after the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
As we shift our focus away from the X-Ray Converter and towards the Lambda Extension and L2T, we wanted a blog post or some type of doc comparing Datadog APM and AWS X-Ray
After all, the title to the guide from the other page says "Decide When to Use Datadog APM and AWS X-Ray"
We have another integration page for X-Ray that's better maintained with the same setup instructions so I'm opting to link to that instead of repeating.
This will remove the per-runtime x-ray client libraries instructions but those aren't very valuable anyway IMO. We're just repeating info from AWS for Node and Python. We simply link to aws docs for the other runtimes anyway
Questions for reviewer
I’m curious about the overall message we're conveying, should we should “less harsh” in the comparison to AWS X-Ray?
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes