Skip to content

DOCS-10828: Making Extension logging behavior more obvious #29560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented May 27, 2025

What does this PR do? What is the motivation?

Many users report issues with duplicate logs due to not realizing the Extension enables log collection by default. Making this more explicit.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@cswatt cswatt requested review from a team as code owners May 27, 2025 16:15
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edits to make "extension" lowercase. I wasn't sure if "Forwarder" needed to be capitalized but left it that way. Approved so you can merge at will!

Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com>
@cswatt
Copy link
Contributor Author

cswatt commented May 27, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 27, 2025

View all feedbacks in Devflow UI.

2025-05-27 22:32:01 UTC ℹ️ Start processing command /merge


2025-05-27 22:32:07 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-28 00:02:40 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-28 00:20:44 UTC ℹ️ MergeQueue: This merge request was merged

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again to test CI

Copy link
Contributor

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@dd-mergequeue dd-mergequeue bot merged commit ed2e6c5 into master May 28, 2025
20 of 25 checks passed
@dd-mergequeue dd-mergequeue bot deleted the cswatt/svl-ext-logs branch May 28, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants