Skip to content

Update aggregation key processor documentation to reflect new source inclusion changes #30018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

fraseriver
Copy link
Contributor

@fraseriver fraseriver commented Jun 18, 2025

What does this PR do? What is the motivation?

ECT-3509

An additional line has been added to this documentation to reflect that @evt.source_id and @evt.integration_id are now always included in the aggregation key generation, meaning events with different sources will always have distinct aggregation keys.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@fraseriver fraseriver requested a review from a team as a code owner June 18, 2025 18:34
Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit per the style guide

…aggregation_key.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@fraseriver fraseriver requested a review from buraizu June 18, 2025 18:49
@fraseriver
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2025

View all feedbacks in Devflow UI.

2025-06-24 17:34:00 UTC ℹ️ Start processing command /merge


2025-06-24 17:34:07 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.


2025-06-24 18:01:42 UTC ⚠️ MergeQueue: This merge request was unqueued

sam.fraser@datadoghq.com unqueued this merge request

@fraseriver
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2025

View all feedbacks in Devflow UI.

2025-06-24 18:01:36 UTC ℹ️ Start processing command /merge -c

@fraseriver
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2025

View all feedbacks in Devflow UI.

2025-06-24 18:02:06 UTC ℹ️ Start processing command /merge


2025-06-24 18:02:11 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.


2025-06-24 18:03:37 UTC ⚠️ MergeQueue: This merge request was unqueued

sam.fraser@datadoghq.com unqueued this merge request

@fraseriver
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2025

View all feedbacks in Devflow UI.

2025-06-24 18:03:31 UTC ℹ️ Start processing command /merge -c

@fraseriver fraseriver merged commit 7ab77c3 into master Jun 24, 2025
30 of 36 checks passed
@fraseriver fraseriver deleted the sam.fraser/update-agg-key-processor-documentation branch June 24, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants