Skip to content

fix(appsec): update aap/iast versions #30032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Jun 20, 2025

What does this PR do? What is the motivation?

Refactor related for this PR: #30029

  • Move common tables to a layer
  • Update Python versions supported for AAP
  • Update Python versions supported for IAST
  • Update IAST min version

The style of the tables is exactly the same

PR:
image

PRO:
image

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jun 20, 2025
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@avara1986 avara1986 marked this pull request as ready for review June 20, 2025 10:10
@avara1986 avara1986 requested review from a team as code owners June 20, 2025 10:10
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tables is duplicated. Another one is failing to render. I'm not sure why, but I'm wondering if it's an interaction with the collapsing section. Partials sometimes don't play nicely when they're inside of shortcodes.

@avara1986 avara1986 requested a review from hestonhoffman June 23, 2025 06:57
@avara1986 avara1986 merged commit 934a1e3 into master Jun 24, 2025
30 of 33 checks passed
@avara1986 avara1986 deleted the avara1986/fix_appsec_min_versions branch June 24, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants