Skip to content

Clarify Azure Container Apps instrumentation instructions for shared volumes #30090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Jun 24, 2025

What does this PR do? What is the motivation?

This PR clarifies that the shared log volume should be added to both the sidecar container and the user's application container(s).

This was not obvious before this change, and might have led to some frustration from customers.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@nhulston nhulston requested review from a team as code owners June 24, 2025 16:30
Copy link
Contributor

github-actions bot commented Jun 24, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this!

@brett0000FF brett0000FF merged commit b67dc87 into master Jun 24, 2025
21 of 23 checks passed
@brett0000FF brett0000FF deleted the nicholas.hulston/clarify-azure-sidecar-instrumentation branch June 24, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants