-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[azure-container-apps] Tell customers to use type "ephemeral storage" for the log volume #30126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure-container-apps] Tell customers to use type "ephemeral storage" for the log volume #30126
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
Preview links (active after the
|
@@ -26,7 +26,7 @@ Custom metrics are also collected through the tracer. See the [code examples][2] | |||
#### Logs | |||
The Datadog sidecar uses file tailing to collect logs. | |||
|
|||
In Azure, add a volume mount to the sidecar container *and* your application containers using [replica-scoped storage][5]. The examples on this page use the volume name `logs` and the mount path `/LogFiles`. | |||
In Azure, add a volume mount to the sidecar container *and* your application containers using [replica-scoped storage][5]. Use type "Ephemeral storage" when creating your volume. The examples on this page use the volume name `logs` and the mount path `/LogFiles`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 I know this is a can of worms that's not primarily related to the change you intended. But, I see that there's a lot of content that's duplicated in this file. My understanding is that we use Hugo for our docs site which supports using shortcodes for content that's either completely duplicated or almost duplicated in multiple places. It would be good to utilize it and define the contents in one place and reuse it.
Example Links:
- Defining a reusable shortcode (name, link and avatar are params)
- Reusing the shortcode while passing the parameters
- I would recommend creating a folder for serverless shortcodes similar to OTEL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a good idea @clifordshelton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! We're working on GCP Docs refresh right now, and we need to tackle Azure docs refresh after
What does this PR do? What is the motivation?
We currently link to a Microsoft article about replica-scoped storage, but we never explicitly say to use "Ephemeral storage" as the file volume type.
We've had multiple tickets opened due to this misconfiguration -- this change is intended to make the onboarding process easier and prevent these tickets.
This is required -- otherwise, users will receive duplicated logs when there is more than one replica of the container.
Merge instructions
Merge readiness:
Additional notes