Skip to content

[azure-container-apps] Tell customers to use type "ephemeral storage" for the log volume #30126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Jun 25, 2025

What does this PR do? What is the motivation?

We currently link to a Microsoft article about replica-scoped storage, but we never explicitly say to use "Ephemeral storage" as the file volume type.

We've had multiple tickets opened due to this misconfiguration -- this change is intended to make the onboarding process easier and prevent these tickets.

This is required -- otherwise, users will receive duplicated logs when there is more than one replica of the container.

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

Copy link
Contributor

github-actions bot commented Jun 25, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@nhulston nhulston changed the title [serverless-init][azure-container-apps] Tell customers to use type "ephemeral storage" for the log volume [azure-container-apps] Tell customers to use type "ephemeral storage" for the log volume Jun 25, 2025
@nhulston nhulston marked this pull request as ready for review June 25, 2025 20:47
@nhulston nhulston requested review from a team as code owners June 25, 2025 20:47
@@ -26,7 +26,7 @@ Custom metrics are also collected through the tracer. See the [code examples][2]
#### Logs
The Datadog sidecar uses file tailing to collect logs.

In Azure, add a volume mount to the sidecar container *and* your application containers using [replica-scoped storage][5]. The examples on this page use the volume name `logs` and the mount path `/LogFiles`.
In Azure, add a volume mount to the sidecar container *and* your application containers using [replica-scoped storage][5]. Use type "Ephemeral storage" when creating your volume. The examples on this page use the volume name `logs` and the mount path `/LogFiles`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 I know this is a can of worms that's not primarily related to the change you intended. But, I see that there's a lot of content that's duplicated in this file. My understanding is that we use Hugo for our docs site which supports using shortcodes for content that's either completely duplicated or almost duplicated in multiple places. It would be good to utilize it and define the contents in one place and reuse it.

Example Links:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a good idea @clifordshelton

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! We're working on GCP Docs refresh right now, and we need to tackle Azure docs refresh after

@drichards-87 drichards-87 merged commit 7db0d97 into master Jun 26, 2025
24 of 26 checks passed
@drichards-87 drichards-87 deleted the nicholas.hulston/azure-container-apps-use-ephemeral-volume-type branch June 26, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants