Skip to content

Add Debug, JSON Format options for Java Tracer logs #30141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 27, 2025
Merged

Add Debug, JSON Format options for Java Tracer logs #30141

merged 8 commits into from
Jun 27, 2025

Conversation

cecile75
Copy link
Contributor

@cecile75 cecile75 commented Jun 26, 2025 •
edited
Loading

What does this PR do? What is the motivation?

  • Add JSON Format Option for Java Tracer logs in configuration and debug logs page
  • Add debug logs option in configuration page
  • Fix some formatting consistency in configuration page
  • Fix debug logs example in configuration page

Merge instructions

Merge readiness:

  • [ x] Ready for merge

Additional notes

@cecile75 cecile75 requested a review from a team as a code owner June 26, 2025 12:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025 •
edited
Loading

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@cecile75 cecile75 requested a review from bm1549 June 26, 2025 13:07
@cecile75 cecile75 added tracing Content changed in the tracing folder labels Jun 26, 2025
bm1549
bm1549 reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can we also include this on the Java configuration page in case folks look there as well?

drichards-87
drichards-87 requested changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small suggestions.

cecile75 and others added 5 commits June 27, 2025 10:18
@cecile75 cecile75 changed the title Add JSON Format Option for Java Tracer logs Add Debug, JSON Format options for Java Tracer logs Jun 27, 2025
@cecile75 cecile75 requested review from drichards-87 and bm1549 June 27, 2025 11:21
bm1549
bm1549 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving our docs 🙌

drichards-87
drichards-87 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion and approved the PR.

cecile75 and others added 2 commits June 27, 2025 17:18
@cecile75 cecile75 merged commit 837ecef into master Jun 27, 2025
15 checks passed
@cecile75 cecile75 deleted the cecile/APMJAVATracerAddJSONFormatOption branch June 27, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bm1549 bm1549 bm1549 approved these changes

@drichards-87 drichards-87 drichards-87 approved these changes

Assignees
No one assigned
Labels
tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecile75 @bm1549 @drichards-87