fix: Test command line result before comparing it to Gunicorn master name #19310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Can you add a changelog for this change? |
dax
force-pushed
the
fix-gunicorn-check
branch
from
f3228c0 to
2be1499
Compare
|
@HadhemiDD I have added a changelog line for this change. |
cswatt
previously approved these changes
Jan 8, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
dax
force-pushed
the
fix-gunicorn-check
branch
from
2be1499 to
88b99e1
Compare
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
temporal-github-worker-1
bot
added
agent/requested-changes
and removed
agent/review-requested
labels
dax
force-pushed
the
fix-gunicorn-check
branch
from
88b99e1 to
ab72542
Compare
|
@iliakur I have added a test and used |
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/requested-changes
docs/review-requested
labels
sarah-witt
reviewed
Jun 23, 2025
temporal-github-worker-1
bot
dismissed
iliakur’s stale review
Review from iliakur is dismissed. Related teams and files:
- agent-integrations
- gunicorn/datadog_checks/gunicorn/gunicorn.py
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
sarah-witt
approved these changes
Jun 23, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Kyle-Neale
pushed a commit
that referenced
this pull request
Jun 24, 2025
…name (#19310) * fix: Test command line result before comparing it to Gunicorn master name * Update gunicorn/datadog_checks/gunicorn/gunicorn.py --------- Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It tests the result of
psutil.cmdline()before comparing its first element to the Gunicorn master process name.Motivation
On Linux
psutil.cmdline()may return an empty array (e.g. for kernel processes) makingcmdline()[0]fail with anIndexError: list index out of rangeerror.Even if the
IndexErrorwas caught, it generates a lot of noise in logs. Moreover, as there is an attached exception to aDEBUGlog, Datadog classifies it as an error which is misleading.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged