Update pan_firewall README.md to include enabling logs #20143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous documentation didn't include the note that log collection had to be enabled. My customer didn't have logs enabled in their test environment and had to debug to see the issue.
jhgilbert
reviewed
Apr 24, 2025
Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com>
jhgilbert
reviewed
Apr 25, 2025
Added numbered link 10 to log documentation
jhgilbert
approved these changes
Apr 25, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
sarah-witt
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous documentation didn't include the note that log collection had to be enabled. My customer didn't have logs enabled in their test environment and had to debug to see the issue.
What does this PR do?
Adds a note about making sure that log_collection is enabled.
Motivation
My customer is testing PAN and didn't have logs enabled in test. They found the error in logs, but it should be specified in docs.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged