[MLOB-2838] add nanodollar unit to list of valid metric units #20341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Kim
force-pushed
the
yunkim/add-nanodollar-valid-unit
branch
from
2f9031f to
2d6ca09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Yun-Kim
changed the title
sarah-witt
approved these changes
May 20, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
steveny91
approved these changes
Jun 13, 2025
|
/mergegate trigger |
|
View all feedbacks in Devflow UI.
Merge gate not updated, no change detected in status or details on integrations-core #20341 synced on DB: success |
steveny91
removed this pull request from the merge queue due to the queue being cleared
steveny91
removed this pull request from the merge queue due to the queue being cleared
|
/mergegate trigger |
|
View all feedbacks in Devflow UI.
Merge gate not updated, no change detected in status or details on integrations-core #20341 synced on DB: success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds nanodollar unit to the list of valid units. See https://github.com/DataDog/dd-source/pull/220160 and https://github.com/DataDog/dogweb/pull/142407 for corresponding PRs to add the nanodollar unit.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged