-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DBMON-5416 Collect table size metrics for SQLServer #20367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edengorevoy
merged 14 commits into
master
from
eden.gorevoy/table-size-metrics-sqlserver
May 29, 2025
Merged
DBMON-5416 Collect table size metrics for SQLServer #20367
edengorevoy
merged 14 commits into
master
from
eden.gorevoy/table-size-metrics-sqlserver
May 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d13ea6c
to
8d3f9f1
Compare
8d3f9f1
to
6ef6664
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lu-zhengda
previously approved these changes
May 27, 2025
Review from lu-zhengda is dismissed. Related teams and files:
- database-monitoring-agent
- sqlserver/metadata.csv
c75d9cc
to
444e20e
Compare
lu-zhengda
approved these changes
May 28, 2025
domalessi
pushed a commit
that referenced
this pull request
May 29, 2025
* Sqlserver table size metrics * wip * Wip * Collect table size metrics for SQLServer * Format * Exclude tempdb * Changelog * Validate * Integration test * Style * Metadata file * License * Skip table size metrics for windows * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a configuration option to collect table size metrics, in kibibytes, for SQLserver:
sqlserver.table.row_count
sqlserver.table.total_size
sqlserver.table.used_size
sqlserver.table.data_size
Each is tagged by
table
,database
andschema
. We query fromsys.dm_db_partition_stats
andsys.allocation_units
to grab this information.tempdb is excluded from these metrics.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged